Skip to content

Extra device info #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 23, 2020
Merged

Extra device info #147

merged 15 commits into from
Oct 23, 2020

Conversation

1e-to
Copy link
Contributor

@1e-to 1e-to commented Oct 19, 2020

The PR closes #113 and closes #81.

@1e-to 1e-to requested a review from PokhodenkoSA October 19, 2020 15:12
@PokhodenkoSA
Copy link
Contributor

Linux CI fails.

Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Needs some minor clean ups and should be ready.

Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Please fix the one small naming change in C++ test case and it is good to go. Thanks!

{
DPPLSyclDeviceRef OpenCL_cpu = nullptr;
DPPLSyclDeviceRef OpenCL_gpu = nullptr;
DPPLSyclDeviceRef OpenCL_level_zero = nullptr;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call it Level0_gpu. OpenCl and Level0 are different driver stacks for the same GPU device.

@diptorupd
Copy link
Contributor

@1e-to please rebase with master and I can merge it tomorrow.

return D->is_cpu();
}
return false;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

return D->get_info<info::device::max_compute_units>();
}
return 0;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@PokhodenkoSA PokhodenkoSA merged commit 26bf594 into IntelPython:master Oct 23, 2020
@1e-to 1e-to deleted the extra_device_info branch March 2, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants