-
Notifications
You must be signed in to change notification settings - Fork 29
Extra device info #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra device info #147
Conversation
Linux CI fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Needs some minor clean ups and should be ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. Please fix the one small naming change in C++ test case and it is good to go. Thanks!
{ | ||
DPPLSyclDeviceRef OpenCL_cpu = nullptr; | ||
DPPLSyclDeviceRef OpenCL_gpu = nullptr; | ||
DPPLSyclDeviceRef OpenCL_level_zero = nullptr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call it Level0_gpu. OpenCl and Level0 are different driver stacks for the same GPU device.
@1e-to please rebase with master and I can merge it tomorrow. |
return D->is_cpu(); | ||
} | ||
return false; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return D->get_info<info::device::max_compute_units>(); | ||
} | ||
return 0; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR closes #113 and closes #81.