Correct use ERRORLEVEL in conda scripts for Windows #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have finished reading the article mentioned. If env var %ERRORLEVEL% is not set then access to it will fallback to exit value. So setting ERRORLEVEL in oneAPI scripts is an error, but using it in conda scripts is not an error. |
|
I am fine with this change. Maybe open a ticket for oneAPI, but not a very high priority. |
diptorupd
approved these changes
Sep 11, 2020
This reverts commit b42a7e1.
|
I have returned old checks style |
diptorupd
pushed a commit
to diptorupd/dpctl
that referenced
this pull request
Sep 15, 2020
* Correct use of ERRORLEVEL in cmd scripts. * Reset 0 after oneAPI env activateion in build and test scripts. * Revert "Correct use of ERRORLEVEL in cmd scripts." This reverts commit b42a7e1.
diptorupd
added a commit
to diptorupd/dpctl
that referenced
this pull request
Sep 15, 2020
diptorupd
added a commit
to diptorupd/dpctl
that referenced
this pull request
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I build conda package on Windows in my local environment it fails on tests.
It happens because oneAPI env activation script (part related to FPGA) does
set ERRORLEVEL=1.As mentioned in this article in cmd.exe scripts
IF ERRORLEVEL 1 ...checks the last exit value butIF %ERROLEVEL% NEQ 0 ...checks env variable. The env variable does not relate to last exit status. I think it is error in oneAPI and conda scripts to use env variable instead of exit value.Current CI works without this modifications but my local env does not work without it.
Also, I have tested it with my last commit on branch beta/2021. When I test in master it crashes on python -c "import dppl". It does not relate to this modifications. Just there is an issue between beta/2021 and current master.