Sycl wrappers #30
Merged
Sycl wrappers #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
requested review from
PokhodenkoSA,
oleksandr-pavlyk and
fschlimb
diptorupd
force-pushed
the
sycl_wrappers
branch
from
5dcf799 to
3af9b6e
Compare
diptorupd
force-pushed
the
sycl_wrappers
branch
2 times, most recently
from
c2479a0 to
7c325f1
Compare
…erfaces.
- Separates out the queue manager from the sycl queue interface wrapper.
- Added API to get context, device froma Sycl queue.
- Added C-API wrappers for sycl device, queue, context interfaces exposing
some of the API functionalities. More can be added as needed.
- The dppl extension now defines extension types for sycl quque, device, context to
mimic the C API.
- Sycl queues are now returned to callers as a SyclQueue extension type rather than
a Py_capsule.
diptorupd
force-pushed
the
sycl_wrappers
branch
from
7c325f1 to
5d81879
Compare
PokhodenkoSA
suggested changes
Sep 16, 2020
|
|
||
| void error_reporter (const std::string & msg) | ||
| { | ||
| throw std::runtime_error("Error: " + msg); |
There was a problem hiding this comment.
If the library provides C interface then all exceptions should not cross the boundary of C API. So all exceptions must be caught inside the library.
Just a point to discuss. Write your thoughts please if you are disagree.
PokhodenkoSA
approved these changes
Sep 17, 2020
New line at EOF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds wrappers for sycl::context and sycl::device classes. In addition, the Sycl queue manager is separated out from the wrapper for sycl::queue. In the Cython extension, we now have three new extension types: SyclQueue, SyclDevice, SyclContext. The SyclQueue class replaces the previous use of a Py_Capsule to store the DPPLSyclQueueRef pointer.
The changes in this PR lay the groundwork for adding the next set of changes needed to move Numba from OpenCL to Sycl.
Still needs unit tests and more documentation, but is otherwise ready for review.