Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for axes keyword to dpnp.matmul #1705

Merged
merged 10 commits into from
Feb 16, 2024
Merged

add support for axes keyword to dpnp.matmul #1705

merged 10 commits into from
Feb 16, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Feb 9, 2024

In this PR, axes keyword is added to dpnp.matmul and new relevant tests are added to the test suite.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Feb 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review February 9, 2024 22:01
antonwolfy
antonwolfy reviewed Feb 10, 2024
View reviewed changes
dpnp/dpnp_iface_linearalgebra.py Outdated Show resolved Hide resolved
dpnp/dpnp_utils/dpnp_utils_linearalgebra.py Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_matmul.py Outdated Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_matmul.py Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_matmul.py Show resolved Hide resolved
dpnp/dpnp_iface_linearalgebra.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Feb 13, 2024
View reviewed changes
dpnp/dpnp_utils/dpnp_utils_linearalgebra.py Outdated Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_matmul.py Outdated Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_matmul.py Outdated Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_matmul.py Outdated Show resolved Hide resolved
dpnp/dpnp_utils/dpnp_utils_linearalgebra.py Outdated Show resolved Hide resolved
@vtavana vtavana requested a review from npolina4 February 13, 2024 21:07
npolina4
npolina4 reviewed Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@npolina4 npolina4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes did not affect dpbench performance.

antonwolfy
antonwolfy approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana !

@vtavana vtavana merged commit 3461932 into master Feb 16, 2024
45 checks passed
@vtavana vtavana deleted the matmul_cupy_test branch February 16, 2024 17:28
github-actions bot added a commit that referenced this pull request Feb 16, 2024
@github-actions @npolina4
add support for axes keyword to dpnp.matmul (#1705)
f2da5da 
* update matmul for cupy tests

* address comments

* address more comments

* fix an error

* use a function for error msg

---------

Co-authored-by: Natalia Polina <natalia.polina@intel.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 3461932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolina4 npolina4 npolina4 left review comments

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @npolina4 @antonwolfy