Align with new array api version in dpctl #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npolina4
approved these changes
Apr 4, 2024
|
View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html |
|
I think we should also update the docstring for relevant functions for returned array data type. |
antonwolfy
force-pushed
the
align-with-new-array-api-version-in-dpctl
branch
from
76e9d3d to
37d4b0e
Compare
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Apr 5, 2024
* Use utility function from dpctl.tensor._type_utils * Align sum and prod tests * Align logsumexp and reduce_hypot tests * Updated docstring of impacted functions 5a3e078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR aligns tests with the recent updates reductions over floating point data implemented in scope of IntelPython/dpctl#1621 as per the 2023.12 array API spec.