-
Notifications
You must be signed in to change notification settings - Fork 29
Update reduction data types for 2023.12 array API specification, update __array_api_version__
#1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_190 ran successfully. |
I think the spec changed default output dtype of reduction operations only for the floating point input dtypes. For integrals previous behavior is correct, but I will double-check. |
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_191 ran successfully. |
Yes, the change to
|
The "array_api_tests/test_special_cases.py::test_unary[signbit(x_i is NaN) -> True]" failure seems like a bug in the test suite. This is the output of
The "0x7fc00000" is hexadecimal view into float32, and it indeed does not have the sign bit set. I filed data-apis/array-api-tests#250 |
Yes, there are a couple more cases too: the The If these failures are still around come time to merge this branch, I will introduce them to the array API test skips file. |
b1219af
to
4bd02b4
Compare
7704aa5
to
65f8e53
Compare
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_195 ran successfully. |
65f8e53
to
d783a2c
Compare
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_196 ran successfully. |
Also changes docstrings in _array_api.py
Floating point data types are no longer promoted based on item size
…o `default_dtypes` throughout tests
d783a2c
to
aa033eb
Compare
aa033eb
to
0722cdf
Compare
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_198 ran successfully. |
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_163 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the a future PR, we could parametrize default dtype functions to take callables that return needed default type given q
. In tests we can use mock functions to reach branches left out by CI runs.
This pull request updates reductions over floating point data to be performed in the input type by default as per the 2023.12 array API spec.
This pull request also changes
__array_api_version__
to 2023.12. Ascumulative_sum
is a requirement of the 2023.12 spec, this PR should be redirected to master after the base branch is merged.