Change dtype=None behavior in sum/prod/cumulative_sum/linalg.trace #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes data-apisgh-731. This is a backwards-incompatible change. It seems justified and necessary because array libraries all behave like the required behavior described in this commit, are not planning to change, and the initial rationale for the "upcast float" requirement wasn't strong. See discussion in data-apisgh-731 for more details.
rgommers
added
Maintenance
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
approved these changes
Feb 13, 2024
6 tasks
tomwhite
added a commit
to cubed-dev/cubed
that referenced
this pull request
Dec 19, 2024
tomwhite
added a commit
to cubed-dev/cubed
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-731. This is a backwards-incompatible change. It seems justified and necessary because array libraries all behave like the required behavior described in this commit, are not planning to change, and the initial rationale for the "upcast float" requirement wasn't strong. See discussion in gh-731 for more details.
It also improves readability; there were too many bullet points and the indentation wasn't working. The explanation of behavior for
dtype=Noneis almost halved in size, making it much easier to understand.