Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check type of input in dpnp.repeat to raise a proper validation exception if any #1894

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Check type of input in dpnp.repeat to raise a proper validation exception if any #1894

merged 3 commits into from
Jun 28, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jun 24, 2024 •
edited
Loading

That PR proposes to add an explicit type check of input array to dpnp.repeat.

Before the change there was the exception raised about missing ndim attribute for scalar input.
The issue come from the comment.

Also the docstring description was updated with more details about supported input arguments. And more tests scenario were added to cover missing use cases.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 24, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review June 27, 2024 17:41
vtavana
vtavana approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
@antonwolfy @vtavana
Update dpnp/dpnp_iface_manipulation.py
b376a1d 
Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
@antonwolfy antonwolfy merged commit 437f046 into master Jun 28, 2024
14 of 39 checks passed
@antonwolfy antonwolfy deleted the type-check-in-repeat branch June 28, 2024 10:37
github-actions bot added a commit that referenced this pull request Jun 28, 2024
@github-actions
Check type of input in dpnp.repeat to raise a proper validation exc…
8ccc506 
…eption if any (#1894)

* Check type of input to raise a proper validation exception if any

* Update dpnp/dpnp_iface_manipulation.py

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>

---------

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> 437f046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana