Fix FFT negative strides case #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderKalistratov
requested review from
antonwolfy,
vlad-perevezentsev and
vtavana
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Thank you @AlexanderKalistratov. I have only a minor comment.
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 27, 2024
* Fix issue with negative strides * Apply suggestions from code review Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 88911fb
vtavana
pushed a commit
that referenced
this pull request
Dec 2, 2024
* Fix issue with negative strides * Apply suggestions from code review Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
vtavana
pushed a commit
that referenced
this pull request
Dec 2, 2024
* Fix issue with negative strides * Apply suggestions from code review Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
antonwolfy
added a commit
that referenced
this pull request
Dec 5, 2024
* Fix issue with negative strides * Apply suggestions from code review Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
antonwolfy
added a commit
that referenced
this pull request
Dec 5, 2024
antonwolfy
added a commit
that referenced
this pull request
Dec 5, 2024
AlexanderKalistratov
added a commit
that referenced
this pull request
Feb 4, 2025
* Added keyword `method` to `correlate` function similar to [scipy correlate](https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.correlate.html) * If `method == 'auto'` method is choosing automatically between `direct` and `fft` * Added implementation of fft-based correlation * fft-based implementation may have accuracy issues, so it is validated in non-standard way. Depends on: #2180, #2202 --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Feb 4, 2025
* Added keyword `method` to `correlate` function similar to [scipy correlate](https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.correlate.html) * If `method == 'auto'` method is choosing automatically between `direct` and `fft` * Added implementation of fft-based correlation * fft-based implementation may have accuracy issues, so it is validated in non-standard way. Depends on: #2180, #2202 --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> da2eeba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFT implementation validate arrays for supported strides/dtypes and if needed make a copy and cast (
_copy_array).Old implementation didn't validate for dtype in case of negative strides resulting in incorrect type selection in
_commit_descriptorand failures on systems withoutfloat64support.