Correlation via fft implementation #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderKalistratov
requested review from
antonwolfy,
vlad-perevezentsev and
vtavana
as code owners
AlexanderKalistratov
force-pushed
the
correlate_fft
branch
from
f18bbf2 to
698c65e
Compare
AlexanderKalistratov
changed the title
AlexanderKalistratov
force-pushed
the
correlate
branch
from
2514037 to
6fc7166
Compare
AlexanderKalistratov
force-pushed
the
correlate_fft
branch
from
698c65e to
5963304
Compare
AlexanderKalistratov
force-pushed
the
correlate
branch
from
fbc94d0 to
fa3af10
Compare
AlexanderKalistratov
force-pushed
the
correlate_fft
branch
from
5963304 to
5f429be
Compare
AlexanderKalistratov
force-pushed
the
correlate
branch
from
fa3af10 to
70a7d8d
Compare
AlexanderKalistratov
force-pushed
the
correlate
branch
2 times, most recently
from
936870b to
be09e32
Compare
AlexanderKalistratov
force-pushed
the
correlate
branch
from
be09e32 to
91fd41f
Compare
AlexanderKalistratov
force-pushed
the
correlate_fft
branch
from
5f429be to
6eb94b2
Compare
AlexanderKalistratov
force-pushed
the
correlate
branch
from
91fd41f to
943726f
Compare
|
@antonwolfy @vlad-perevezentsev please review |
antonwolfy
reviewed
Jan 17, 2025
AlexanderKalistratov
force-pushed
the
correlate_fft
branch
from
f42bbaa to
7efaf52
Compare
|
Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_31 ran successfully. |
antonwolfy
reviewed
Jan 27, 2025
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
approved these changes
Jan 29, 2025
|
Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_36 ran successfully. |
github-actions bot
added a commit
that referenced
this pull request
Feb 4, 2025
* Added keyword `method` to `correlate` function similar to [scipy correlate](https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.correlate.html) * If `method == 'auto'` method is choosing automatically between `direct` and `fft` * Added implementation of fft-based correlation * fft-based implementation may have accuracy issues, so it is validated in non-standard way. Depends on: #2180, #2202 --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> da2eeba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
methodtocorrelatefunction similar to scipy correlatemethod == 'auto'method is choosing automatically betweendirectandfftDepends on: #2180, #2202