Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows bringup #2537

Merged

Conversation

PranavDhulipala
Copy link

No description provided.

@Nir-Az
Copy link
Collaborator

Nir-Az commented Nov 9, 2022

Hi @PranavDhulipala , thanks for your contribution.

Can you share some data? what ros distro are you using?
Do you manage to build our ROS wrapper for windows with this change?
@SamerKhshiboun FYI
Thanks

@PranavDhulipala
Copy link
Author

Hi @Nir-Az , I used humble distro on Windows. I was able to build and test the ROS wrapper with the changes.

@Nir-Az
Copy link
Collaborator

Nir-Az commented Nov 10, 2022

@SamerKhshiboun / @MartyG-RealSense FYI

@PranavDhulipala Great to hear it works for you.
I will merge this change for supporting your UC.

@Nir-Az Nir-Az self-requested a review November 10, 2022 08:27
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@Nir-Az Nir-Az merged commit 060bf2a into IntelRealSense:ros2-development Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants