Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Proposal deposits and add deposit tests to imp tests #3864

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Fix Proposal deposits and add deposit tests to imp tests #3864

merged 2 commits into from
Nov 10, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Nov 10, 2023

Description

Fixes #3826

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/add-deposits-to-imp-tests branch from 91b82ae to c30b00c Compare November 10, 2023 02:08
aniketd
aniketd approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 what a catch! 💪

@jasagredo jasagredo mentioned this pull request Nov 10, 2023
Closed
53 tasks
Soupstraw
Soupstraw approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lehins lehins merged commit 5c1c24b into master Nov 10, 2023
9 of 297 checks passed
@iohk-bors iohk-bors bot deleted the lehins/add-deposits-to-imp-tests branch November 10, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketd aniketd aniketd approved these changes

@Soupstraw Soupstraw Soupstraw approved these changes

@TimSheard TimSheard Awaiting requested review from TimSheard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deposits for govActions never returned
3 participants
@lehins @aniketd @Soupstraw