Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental transaction signing #3545

Closed
Jimbo4350 opened this issue Jan 27, 2022 · 1 comment · Fixed by #3549
Closed

Incremental transaction signing #3545

Jimbo4350 opened this issue Jan 27, 2022 · 1 comment · Fixed by #3549
Assignees
@Jimbo4350
Labels
area: transaction view comp: cardano-cli enhancement New feature or request type: internal feature Non user-facing functionality user type: internal Created by an IOG employee

Comments

@Jimbo4350
Copy link
Contributor

Implement the ability to incrementally sign a transaction. I.e the ability to sign a transaction, send that signed transaction to another party who will also add his/her signature.
@Jimbo4350 Jimbo4350 added the enhancement New feature or request label Jan 27, 2022
@Jimbo4350 Jimbo4350 self-assigned this Jan 27, 2022
@Jimbo4350 Jimbo4350 mentioned this issue Jan 28, 2022
Merged
@dorin100
Copy link

dorin100 commented Feb 1, 2022 •
edited
Loading

from an end-user perspective, it would be best to be able to see (maybe in the transaction view output):

  • what keys (or at least how many) need to sign the transaction
  • what keys already signed the transaction

iohk-bors bot added a commit that referenced this issue Feb 10, 2022
@iohk-bors @Jimbo4350
Merge #3549
8e49163 
3549: Update transaction sign command to allow for incremental signing r=Jimbo4350 a=Jimbo4350

You can now specify an already signed transaction via `--tx-file` in order to add more signatures to it:  

`cardano-cli transaction sign (--tx-body-file FILE | --tx-file FILE) ...`

Resolves: #3545


Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
iohk-bors bot added a commit that referenced this issue Feb 10, 2022
@iohk-bors @Jimbo4350
Merge #3549
e146899 
3549: Update transaction sign command to allow for incremental signing r=Jimbo4350 a=Jimbo4350

You can now specify an already signed transaction via `--tx-file` in order to add more signatures to it:  

`cardano-cli transaction sign (--tx-body-file FILE | --tx-file FILE) ...`

Resolves: #3545


Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
iohk-bors bot added a commit that referenced this issue Feb 11, 2022
@iohk-bors @Jimbo4350
Merge #3549
abe43b7 
3549: Update transaction sign command to allow for incremental signing r=Jimbo4350 a=Jimbo4350

You can now specify an already signed transaction via `--tx-file` in order to add more signatures to it:  

`cardano-cli transaction sign (--tx-body-file FILE | --tx-file FILE) ...`

Resolves: #3545


Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
iohk-bors bot added a commit that referenced this issue Feb 11, 2022
@iohk-bors @Jimbo4350
Merge #3549
1607fc6 
3549: Update transaction sign command to allow for incremental signing r=Jimbo4350 a=Jimbo4350

You can now specify an already signed transaction via `--tx-file` in order to add more signatures to it:  

`cardano-cli transaction sign (--tx-body-file FILE | --tx-file FILE) ...`

Resolves: #3545


Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
iohk-bors bot added a commit that referenced this issue Feb 15, 2022
@iohk-bors @Jimbo4350
Merge #3549
c56f243 
3549: Update transaction sign command to allow for incremental signing r=Jimbo4350 a=Jimbo4350

You can now specify an already signed transaction via `--tx-file` in order to add more signatures to it:  

`cardano-cli transaction sign (--tx-body-file FILE | --tx-file FILE) ...`

Resolves: #3545


Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors iohk-bors bot closed this as completed in dc578c3 Feb 15, 2022
@dorin100 dorin100 mentioned this issue Feb 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jimbo4350 Jimbo4350

Labels
area: transaction view comp: cardano-cli enhancement New feature or request type: internal feature Non user-facing functionality user type: internal Created by an IOG employee
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update transaction sign command to allow for incremental signing IntersectMBO/cardano-node
2 participants
@Jimbo4350 @dorin100