Update transaction sign command to allow for incremental signing #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
DavidEichmann,
dcoutts,
erikd,
JaredCorduan,
nc6 and
newhoggy
as code owners
11 tasks
newhoggy
approved these changes
Feb 9, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 10, 2022
3549: Update transaction sign command to allow for incremental signing r=Jimbo4350 a=Jimbo4350 You can now specify an already signed transaction via `--tx-file` in order to add more signatures to it: `cardano-cli transaction sign (--tx-body-file FILE | --tx-file FILE) ...` Resolves: #3545 Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
|
Timed out. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 10, 2022
3549: Update transaction sign command to allow for incremental signing r=Jimbo4350 a=Jimbo4350 You can now specify an already signed transaction via `--tx-file` in order to add more signatures to it: `cardano-cli transaction sign (--tx-body-file FILE | --tx-file FILE) ...` Resolves: #3545 Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
|
Timed out. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 11, 2022
3549: Update transaction sign command to allow for incremental signing r=Jimbo4350 a=Jimbo4350 You can now specify an already signed transaction via `--tx-file` in order to add more signatures to it: `cardano-cli transaction sign (--tx-body-file FILE | --tx-file FILE) ...` Resolves: #3545 Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
|
Timed out. |
cblp
previously requested changes
Feb 11, 2022
cardano-cli/src/Cardano/CLI/Types.hs
Outdated
| = TxFile FilePath | ||
| deriving Show | ||
|
|
||
| data TxBodyOrTxFile |
There was a problem hiding this comment.
I'll reconcile this on Monday
|
bors r+ |
|
👎 Rejected by code reviews |
Jimbo4350
dismissed
cblp’s stale review
I will reconcile TxBodyOrTxFile and InputTxFile in a follow up PR
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 11, 2022
3549: Update transaction sign command to allow for incremental signing r=Jimbo4350 a=Jimbo4350 You can now specify an already signed transaction via `--tx-file` in order to add more signatures to it: `cardano-cli transaction sign (--tx-body-file FILE | --tx-file FILE) ...` Resolves: #3545 Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
|
bors r- |
|
Canceled. |
transaction. Previously we could only sign transaction bodies and therefore this allows incremental transaction signing.
Jimbo4350
force-pushed
the
jordan/incremental-signing
branch
from
c21724e to
17bc0c5
Compare
|
bors r+ |
cblp
approved these changes
Feb 15, 2022
iohk-bors bot
added a commit
that referenced
this pull request
Feb 15, 2022
3549: Update transaction sign command to allow for incremental signing r=Jimbo4350 a=Jimbo4350 You can now specify an already signed transaction via `--tx-file` in order to add more signatures to it: `cardano-cli transaction sign (--tx-body-file FILE | --tx-file FILE) ...` Resolves: #3545 Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
|
Timed out. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now specify an already signed transaction via
--tx-filein order to add more signatures to it:cardano-cli transaction sign (--tx-body-file FILE | --tx-file FILE) ...Resolves: #3545