Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script ToJSON instances serialises the full script #4138

Closed
wants to merge 2 commits into from
Closed

Script ToJSON instances serialises the full script #4138

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 5, 2022

There used to be no orphan instance for ledger Script so we (Hydra)
provided our own. This newly introduced instance overlaps with our own
which would not be a problem, as we are fine using upstream instances,
but for the fact the serialisation is lossy as cardano-api only
serialised the hash of the script.

@ghost
Copy link
Author

ghost commented Jul 5, 2022

Note this is an alternative to #4130 which is less principled (still has orphan instance in a place there should be none) but easier to integrate.

abailly added 2 commits July 6, 2022 16:40
There used to be no orphan instance for ledger Script so we (Hydra)
provided our own. This newly introduced instance overlaps with our own
which would not be a problem, as we are fine using upstream instances,
but for the fact the serialisation is lossy as cardano-api only
serialised the hash of the script.
@ch1bo ch1bo changed the base branch from master to release/1.35 July 8, 2022 10:36
@ghost
Copy link
Author

ghost commented Jul 11, 2022

@Jimbo4350 I am trying to update my PR to address comments you made on @ch1bo 's PR #4130, but not sure what's the best approach. There's currently a Shelley.Orphans module in the cardano-cli, do you want me to create a Babbage.Orphans module that would contain this script instance?

Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@dcoutts dcoutts changed the base branch from release/1.35 to master July 22, 2022 20:05
@dcoutts dcoutts changed the base branch from master to release/1.35 July 22, 2022 20:05
@dcoutts
Copy link
Contributor

dcoutts commented Jul 22, 2022

Oh I see I should have approved #4223 which is the version rebased on the master branch.

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you squash the commits?

@ch1bo
Copy link
Contributor

ch1bo commented Jul 25, 2022

@Jimbo4350 would need to open another branch on origin for that. I have squashed & rebased on the master PR. We would love to get it after master also onto release/1.35 but not sure what the policy is.

iohk-bors bot added a commit that referenced this pull request Jul 26, 2022
4223: Script ToJSON instances serialises the full script r=ch1bo a=ch1bo

Mirrored changes of #4138 on origin `cardano-node` repository and targeting `master` per request of `@Jimbo4350` 

Co-authored-by: Arnaud Bailly <arnaud.bailly@iohk.io>
@ch1bo
Copy link
Contributor

ch1bo commented Jul 27, 2022

This change was merged now on master. Shall we close this and cherry-pick the commit from master onto release/1.35 instead?

@newhoggy
Copy link
Contributor

newhoggy commented Apr 3, 2023

Looks like this has already been merged into the release branch. Closing.

@newhoggy newhoggy closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants