Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script ToJSON instances serialises the full script #4223

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Script ToJSON instances serialises the full script #4223

merged 1 commit into from
Jul 26, 2022

Conversation

ch1bo
Copy link
Contributor

@ch1bo ch1bo commented Jul 22, 2022

Mirrored changes of #4138 on origin cardano-node repository and targeting master per request of @Jimbo4350

@dcoutts dcoutts mentioned this pull request Jul 22, 2022
Closed
dcoutts
dcoutts approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me.

@ch1bo
Copy link
Contributor Author

ch1bo commented Jul 25, 2022

Thanks. The build error on Windows seems unrelated? How can we get this merged now?

Jimbo4350
Jimbo4350 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you squash the commits?

@abailly @ch1bo
Script ToJSON instances serialises the full script
8794da7 
There used to be no orphan instance for ledger Script so we (Hydra)
provided our own. This newly introduced instance overlaps with our own
which would not be a problem, as we are fine using upstream instances,
but for the fact the serialisation is lossy as cardano-api only
serialised the hash of the script.
@ch1bo ch1bo force-pushed the complete-script-tojson-instance branch from 739305f to 8794da7 Compare July 25, 2022 14:58
@ch1bo
Copy link
Contributor Author

ch1bo commented Jul 25, 2022 •
edited
Loading

Can you squash the commits?

Squashed and rebased on latest master

@ch1bo
Copy link
Contributor Author

ch1bo commented Jul 26, 2022

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 26, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 803881b into master Jul 26, 2022
@iohk-bors iohk-bors bot deleted the complete-script-tojson-instance branch July 26, 2022 07:33
@CarlosLopezDeLara CarlosLopezDeLara mentioned this pull request Jul 27, 2022
Open
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts dcoutts approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ch1bo @dcoutts @Jimbo4350 @abailly