Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for single relay P2P release. #4191

Closed
wants to merge 4 commits into from
Closed

Changes for single relay P2P release. #4191

wants to merge 4 commits into from

Conversation

coot
Copy link
Contributor

@coot coot commented Jul 18, 2022 •
edited
Loading

Requires:

  • Removed P2PWarningDevelopmentNetworkProtocols
  • Modify P2PWarning message
  • Updated ouroboros-network dependency

@coot coot added the networking Issues and PRs related to networking label Jul 18, 2022
@coot coot force-pushed the coot/single-releay-release branch 2 times, most recently from a61dc81 to 67f4710 Compare July 18, 2022 13:25
@coot coot linked an issue Jul 18, 2022 that may be closed by this pull request
Clarify where to get peers from for the node #4193
Closed
@coot coot mentioned this pull request Jul 18, 2022
Closed
13 tasks
@coot coot force-pushed the coot/single-releay-release branch from 67f4710 to dc989e0 Compare July 28, 2022 11:07
@coot coot marked this pull request as ready for review July 28, 2022 11:30
coot added 3 commits August 12, 2022 14:51
@coot
Removed P2PWarningDevelopmentNetworkProtocols
d38f31c 
The warning is not needed as of ouroboros-network#3859.
@coot
Modify P2PWarning message
e031fd5 
P2P is now an early release: we encourage to enable it on at most one of
the relays (if one has more than one relay).  We don't advise yet to use
it on BP nodes.
@coot
Reword where to get peers from in understanding-config-files.md
1560b33 
Fixes input-output-hk/ouroboros-network#3691
@coot coot force-pushed the coot/single-releay-release branch from dc989e0 to 1951d25 Compare August 12, 2022 16:19
@Jimbo4350 Jimbo4350 self-requested a review August 12, 2022 16:46
@coot coot force-pushed the coot/single-releay-release branch from 1951d25 to 97b3b0b Compare August 14, 2022 08:24
@coot coot dismissed Jimbo4350’s stale review August 17, 2022 13:38

The requested change was resolved.

@newhoggy newhoggy mentioned this pull request Aug 19, 2022
Closed
@coot
Copy link
Contributor Author

coot commented Aug 26, 2022

Closing, P2P changes will be postponed. I will write another PR which updates cardano-node which includes this IntersectMBO/ouroboros-network#3975. The P2P changes (publishing of NodeToNodeV_10) were reverted to avoid having broken master branch if Conway is released.

@coot coot closed this Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@deepfire deepfire Awaiting requested review from deepfire

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@jutaro jutaro Awaiting requested review from jutaro

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

Assignees
No one assigned
Labels
DO NOT MERGE networking Issues and PRs related to networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify where to get peers from for the node
3 participants
@coot @newhoggy @Jimbo4350