Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ouroboros-network dependency #4359

Closed
wants to merge 1 commit into from
Closed

Update ouroboros-network dependency #4359

wants to merge 1 commit into from

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Aug 19, 2022 •
edited
Loading

Depends on #4191

@newhoggy newhoggy force-pushed the newhoggy/update-ouroboros-network-dependency branch from 1084051 to c473d17 Compare August 19, 2022 10:55
@coot
Copy link
Contributor

coot commented Aug 19, 2022

Are you aware of #4230?

@newhoggy newhoggy force-pushed the newhoggy/update-ouroboros-network-dependency branch 2 times, most recently from 19e060e to dd4d37d Compare August 19, 2022 12:20
@newhoggy newhoggy force-pushed the newhoggy/update-ouroboros-network-dependency branch from dd4d37d to 0e946cb Compare August 19, 2022 13:15
@newhoggy newhoggy requested a review from mgmeier August 19, 2022 13:16
deepfire
deepfire approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @newhoggy !

coot
coot requested changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR #4191 must be merged first. The changes that you're including from ouroboros-network enable NodeToNodeV_10 (p2p). #4191 will be a basis for the initial p2p release, which we want to include as little changes from other components as possible.

@newhoggy newhoggy requested a review from coot August 19, 2022 13:30
@newhoggy newhoggy mentioned this pull request Aug 19, 2022
Merged
@coot coot mentioned this pull request Aug 19, 2022
Closed
deepfire
deepfire suggested changes Aug 22, 2022
View reviewed changes
nix/workbench/shell.nix Outdated
@@ -88,7 +88,6 @@ in project.shellFor {
nativeBuildInputs = with pkgs; with haskellPackages; with cardanoNodePackages; [
cardano-ping
cabalWrapped
db-analyser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newhoggy, can we avoid removing db-analyser -- since that breaks the workbench?

@newhoggy newhoggy force-pushed the newhoggy/update-ouroboros-network-dependency branch from 0e946cb to fcb84da Compare August 23, 2022 11:11
@newhoggy newhoggy requested a review from fmaste as a code owner August 23, 2022 11:11
@coot coot mentioned this pull request Aug 26, 2022
Closed
@coot
Copy link
Contributor

coot commented Aug 26, 2022

Closing in favour of #4392.

@coot coot closed this Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire requested changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@jutaro jutaro Awaiting requested review from jutaro

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@mgmeier mgmeier Awaiting requested review from mgmeier

@coot coot Awaiting requested review from coot

@fmaste fmaste Awaiting requested review from fmaste

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@newhoggy @coot @deepfire @mgmeier