Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep alive will not stop when instrumented to do so #4163

Closed
coot opened this issue Nov 18, 2022 · 1 comment · Fixed by #4168
Closed

Keep alive will not stop when instrumented to do so #4163

coot opened this issue Nov 18, 2022 · 1 comment · Fixed by #4168
Labels
bug Something isn't working keep-alive Issues / PRs related to keep-alive protocol

Comments

@coot
Copy link
Contributor

coot commented Nov 18, 2022 •
edited
Loading

continueForever must not be used by the hCeepAliveClient.

It could be ok, I am just not 💯% sure.
@coot coot added the bug Something isn't working label Nov 18, 2022
@coot coot mentioned this issue Nov 21, 2022
Merged
9 tasks
@coot coot added networking keep-alive Issues / PRs related to keep-alive protocol labels Nov 21, 2022
@coot
Copy link
Contributor Author

coot commented Nov 21, 2022 •
edited
Loading

Fixing this ought to clear the following log errors:

{
  "app": [],
  "at": "2022-11-03T09:13:50.50Z",
  "data": {
    "kind": "PeerStatusChangeFailure",
    "peerStatusChangeType": "WarmToCold (ConnectionId {localAddress = 192.168.0.10:7000, remoteAddress = 3.129.186.40:3000})",
    "reason": "TimeoutError"
  },
  "env": "1.35.5:28b76",
  "host": "waldorf",
  "loc": null,
  "msg": "",
  "ns": [
    "cardano.node.PeerSelectionActions"
  ],
  "pid": "3453858",
  "sev": "Error",
  "thread": "1504"
}

iohk-bors bot added a commit that referenced this issue Nov 21, 2022
@iohk-bors @erikd @coot
Merge #4144 #4168
4924411 
4144: Add support for CHaP and ghc-9.2 r=angerman a=erikd

Builds with both ghc-8.10 and ghc-9.2.

Currently uses a `source-package-repository` reference to a `cardano-ledger` PR that has not yet been merged.

4168: Pass ControlMessageSTM to keep-alive client r=coot a=coot

# Description

Fixes #4163.



Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Co-authored-by: Marcin Szamotulski <coot@coot.me>
@iohk-bors iohk-bors bot closed this as completed in 567f9ba Nov 21, 2022
@iohk-bors iohk-bors bot moved this to Done in Ouroboros Network Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working keep-alive Issues / PRs related to keep-alive protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass ControlMessageSTM to keep-alive client IntersectMBO/ouroboros-network
1 participant
@coot