Pass ControlMessageSTM to keep-alive client #4168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolt12
approved these changes
Nov 21, 2022
|
BTW, this fix does not introduces a bug because each protocol temperature is supported by a separate |
dnadales
approved these changes
Nov 21, 2022
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 21, 2022
4144: Add support for CHaP and ghc-9.2 r=angerman a=erikd Builds with both ghc-8.10 and ghc-9.2. Currently uses a `source-package-repository` reference to a `cardano-ledger` PR that has not yet been merged. 4168: Pass ControlMessageSTM to keep-alive client r=coot a=coot # Description Fixes #4163. Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com> Co-authored-by: Marcin Szamotulski <coot@coot.me>
|
Build failed (retrying...): |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 21, 2022
4170: Pick two changes for 1.35.5 r=coot a=coot # Description Pick two commits from the following two PRs: * #4167 * #4168 * #4159 (to fix GitHub Actions on Windows) **Note:** if we decide two include these patches in `1.35.5`, they also must bee included in `1.36.0`. # Checklist - Branch - [x] Commit sequence broadly makes sense - [x] Commits have useful messages - [ ] New tests are added if needed and existing tests are updated - [ ] If this branch changes Consensus and has any consequences for downstream repositories or end users, said changes must be documented in [`interface-CHANGELOG.md`](../ouroboros-consensus/docs/interface-CHANGELOG.md) - [ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in [`interface-CHANGELOG.md`](../docs/interface-CHANGELOG.md) - [ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional. - Pull Request - [x] Self-reviewed the diff - [ ] Useful pull request description at least containing the following information: - What does this PR change? - Why these changes were needed? - How does this affect downstream repositories and/or end-users? - Which ticket does this PR close (if any)? If it does, is it [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)? - [x] Reviewer requested Co-authored-by: Marcin Szamotulski <coot@coot.me> Co-authored-by: Karl Knutsson <karl.fb.knutsson@gmail.com> Co-authored-by: Moritz Angermann <moritz.angermann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4163.
Checklist
interface-CHANGELOG.mdinterface-CHANGELOG.md