Use the real Allegra and Mary era tags #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft because this depends on IntersectMBO/cardano-ledger#1902. |
mrBliss
force-pushed
the
mrBliss/real-era-tags
branch
from
cb51397
to
bd5f2d1
Compare
This was referenced Oct 12, 2020
Merged
mrBliss
force-pushed
the
mrBliss/real-era-tags
branch
2 times, most recently
from
bca2cd0
to
ad7a4ac
Compare
This was referenced Oct 20, 2020
mrBliss
force-pushed
the
mrBliss/real-era-tags
branch
from
ad7a4ac
to
51c4dd9
Compare
|
Rebased and nearly ready. This includes #2716 until merged. The implementation is done, but the tests are still blocked by one thing (AFAIK, unless the current compile errors are hiding other problems): the generators for the serialisation tests in the ledger only work for the Shelley era, not for the Allegra and Mary eras. Because of how our generators are written (see #2709), it is PITA to try to work around this. Let's wait for CAD-2119 (we actually only need the easiest subtask of that issue). |
mrBliss
force-pushed
the
mrBliss/real-era-tags
branch
from
51c4dd9
to
4cc0ea8
Compare
coming soon! ish! |
mrBliss
force-pushed
the
mrBliss/real-era-tags
branch
from
4cc0ea8
to
e720b57
Compare
mrBliss
force-pushed
the
mrBliss/real-era-tags
branch
from
bcae0e6
to
db21cf1
Compare
mrBliss
commented
Oct 30, 2020
Comment on lines
+21
to
+25
| arbitrary = arbitraryBoundedEnum | ||
|
|
||
| shrink v | ||
| | v == minBound = [] | ||
| | otherwise = [pred v] |
There was a problem hiding this comment.
This way it's future-proof
mrBliss
force-pushed
the
mrBliss/real-era-tags
branch
2 times, most recently
from
72a89f2
to
57d0069
Compare
The ledger state format changed because of IntersectMBO/cardano-ledger#1968 The decoder is backwards-compatible, so the ledger doesn't break binary compatibility. The other visible change is IntersectMBO/cardano-ledger#1966
mrBliss
force-pushed
the
mrBliss/real-era-tags
branch
from
57d0069
to
2395603
Compare
Fixes #2670. Without these new versions, nodes forked to Allegra or Mary can no longer communicate with other nodes or clients.
mrBliss
force-pushed
the
mrBliss/real-era-tags
branch
from
2395603
to
1f4735d
Compare
|
bors merge |
|
Build succeeded: |
mrBliss
added a commit
that referenced
this pull request
Nov 13, 2020
Unrelated to this PR, but spotted during review. This was forgotten in #2679.
mrBliss
added a commit
that referenced
this pull request
Nov 13, 2020
Unrelated to this PR, but spotted during review. This was forgotten in #2679.
coot
pushed a commit
that referenced
this pull request
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2668.
Previously, the Allegra and Mary eras were exactly the same as the Shelley era,
so no translations between the eras were needed.
In this commit, we use the actual, different
AllegraEraandShelleyEratags.This means we need translations between the eras.