Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index-state to 2020-10-01 #2693

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Update index-state to 2020-10-01 #2693

merged 1 commit into from
Oct 20, 2020

Conversation

newhoggy
Copy link
Contributor

No description provided.

@newhoggy newhoggy force-pushed the update-index-state-to-2020-10-01 branch 2 times, most recently from 340bace to 02bee52 Compare October 20, 2020 06:59
mrBliss
mrBliss reviewed Oct 20, 2020
View reviewed changes
cabal.project Outdated Show resolved Hide resolved
cabal.project Outdated Show resolved Hide resolved
cabal.project Outdated Show resolved Hide resolved
@mrBliss
Copy link
Contributor

mrBliss commented Oct 20, 2020

@newhoggy I'm curious why you are pushing this change. cardano-node already uses the new index-state. Is it just for consistency?

It's just that it's not ideal when people unrelated to the repo or dependency, update a dependency that might cause lots of breaking changes (see the CI failures). I'm currently working on a dependency update of cardano-ledger-specs in #2679, but first three more PRs (IntersectMBO/cardano-ledger#1922, IntersectMBO/cardano-ledger#1902, IntersectMBO/cardano-ledger#1923) need to be merged in cardano-ledger-specs.

Unless you can drop the dependency bump of cardano-ledger-specs, this PR will have to wait until the four PRs I mentioned are merged.

@newhoggy newhoggy force-pushed the update-index-state-to-2020-10-01 branch from 02bee52 to 6477e16 Compare October 20, 2020 08:48
@newhoggy
Copy link
Contributor Author

newhoggy commented Oct 20, 2020 •
edited
Loading

Thanks for your advice. Fortunately, the earlier decision to make the new version of cardano-prelude backwards compatible means I ought to be able to do as you suggest and not bump cardano-ledger-spec. I'll try that now and see how it goes.

@newhoggy newhoggy force-pushed the update-index-state-to-2020-10-01 branch from 6477e16 to 3fb01d0 Compare October 20, 2020 10:00
@mrBliss mrBliss self-requested a review October 20, 2020 10:14
@mrBliss
Copy link
Contributor

mrBliss commented Oct 20, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 20, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit 95c9cd2 into master Oct 20, 2020
@iohk-bors iohk-bors bot deleted the update-index-state-to-2020-10-01 branch October 20, 2020 10:38
coot pushed a commit that referenced this pull request May 16, 2022
@iohk-bors @newhoggy
Merge #2693
06609a6 
2693: Update index-state to 2020-10-01 r=mrBliss a=newhoggy



Co-authored-by: John Ky <john.ky@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrBliss mrBliss mrBliss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newhoggy @mrBliss