Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Network.Mux.Compat module #4974

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Removed Network.Mux.Compat module #4974

merged 4 commits into from
Oct 11, 2024

Conversation

coot
Copy link
Contributor

@coot coot commented Oct 1, 2024 •
edited
Loading

Description

  • network-mux: removed the Network.Mux.Compat module
  • network-mux: make MiniProcololBundle a type alias
  • network-mux: stylistic changes

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@coot coot requested a review from a team as a code owner October 1, 2024 08:54
@coot coot force-pushed the coot/removed-network-mux-compat branch from 96c71ca to 6f98bc8 Compare October 1, 2024 09:07
@coot coot added technical debt mux issues related to network-mux labels Oct 1, 2024
@coot coot self-assigned this Oct 1, 2024
@coot coot force-pushed the coot/removed-network-mux-compat branch 3 times, most recently from 3b014a1 to 80660f1 Compare October 1, 2024 20:55
This was referenced Oct 2, 2024
Merged
Open
@coot coot force-pushed the coot/removed-network-mux-compat branch from 80660f1 to 5203666 Compare October 3, 2024 19:38
@coot coot force-pushed the coot/removed-network-mux-compat branch from 5203666 to 91c38f7 Compare October 4, 2024 08:33
bolt12
bolt12 requested changes Oct 8, 2024
View reviewed changes
network-mux/src/Network/Mux/Types.hs Show resolved Hide resolved
network-mux/test/Test/Mux.hs Outdated Show resolved Hide resolved
network-mux/test/Test/Mux.hs Outdated Show resolved Hide resolved
ouroboros-network-framework/src/Ouroboros/Network/Mux.hs Show resolved Hide resolved
@coot coot force-pushed the coot/removed-network-mux-compat branch from 91c38f7 to e599a6a Compare October 10, 2024 06:24
@coot coot force-pushed the coot/removed-network-mux-compat branch from e599a6a to adb0071 Compare October 10, 2024 07:44
@coot coot enabled auto-merge October 11, 2024 15:23
@coot coot added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 11, 2024
@coot coot added this pull request to the merge queue Oct 11, 2024
Merged via the queue into master with commit 53ceed0 Oct 11, 2024
13 checks passed
@coot coot deleted the coot/removed-network-mux-compat branch October 11, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 approved these changes

Assignees

@coot coot

Labels
mux issues related to network-mux technical debt
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coot @bolt12