Randomized ProtocolTimeLimits #4980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/random-chain-sync-time-limits
branch
5 times, most recently
from
42e3a65
to
caa9259
Compare
coot
force-pushed
the
coot/random-chain-sync-time-limits
branch
from
caa9259
to
e5df1e6
Compare
This patch adds a way to randomise `ProtocolTimeLimits` per message, rather than per connection. This is used in `ChainSync` to pick a random timeout in the `MustReply` state.
* Provide kinds for some of the type variables. This improves haddocks. * Added export list for `PeerSharing.Codec` * Not exporting `encodeTxSubmission2` and `decodeTxSubmission2`, they are not used outside of this module, and they are not used in `ouroboros-consensus`.
coot
force-pushed
the
coot/random-chain-sync-time-limits
branch
from
e5df1e6
to
2dd2a19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide access to a pseudo random number generator for consructing
ProtocolTimeLimits. This is used forChainSynctimeout in theStNext StMustReplystate.Depends on:
Checklist
Quality
Maintenance
ouroboros-networkproject.