Skip to content

dmq: node-to-client applications #5173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 10, 2025
Merged

dmq: node-to-client applications #5173

merged 6 commits into from
Sep 10, 2025

Conversation

@crocodile-dentist
Copy link
Contributor

@crocodile-dentist crocodile-dentist commented Jul 29, 2025 •
edited
Loading

Description

-local message submission
-local message notification

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@crocodile-dentist crocodile-dentist self-assigned this Jul 29, 2025
@crocodile-dentist crocodile-dentist requested review from a team as code owners July 29, 2025 13:28
@crocodile-dentist crocodile-dentist added the dmq-node Issues / PRs related to DMQ Node label Jul 29, 2025
@github-project-automation github-project-automation bot moved this to In Progress in Ouroboros Network Jul 29, 2025
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/coot/dmq-node-to-node branch 3 times, most recently from 93d68e0 to 86a6d5b Compare July 29, 2025 17:08
coot
coot requested changes Jul 30, 2025
View reviewed changes
Copy link
Collaborator

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add codec tests to this PR. Even if we change the protocols, they won't change that much (just small changes in the generators).

@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/coot/dmq-node-to-node branch 3 times, most recently from ff6004b to fc7da51 Compare July 31, 2025 15:34
@crocodile-dentist crocodile-dentist marked this pull request as draft July 31, 2025 15:35
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/coot/dmq-node-to-node branch 2 times, most recently from 05da6c0 to 4c9c0a4 Compare August 1, 2025 08:08
coot
coot reviewed Aug 4, 2025
View reviewed changes
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/coot/dmq-node-to-node branch from 4c9c0a4 to 7858cd3 Compare August 4, 2025 14:11
@coot coot force-pushed the coot/dmq-node-to-node branch from c7e804a to 880441d Compare August 5, 2025 07:43
@coot coot linked an issue Aug 6, 2025 that may be closed by this pull request
Implement N2C mithril mini-protocols #5178
Closed
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/coot/dmq-node-to-node branch 6 times, most recently from cf95d94 to dcd0e7a Compare August 7, 2025 13:21
@coot coot force-pushed the coot/dmq-node-to-node branch from 4c1e720 to 0274efd Compare August 7, 2025 14:49
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/coot/dmq-node-to-node branch 2 times, most recently from 704c4ad to 357bd29 Compare August 7, 2025 16:17
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/coot/dmq-node-to-node branch 2 times, most recently from a3b2e3e to 2666c7d Compare September 9, 2025 07:49
coot
coot reviewed Sep 9, 2025
View reviewed changes
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/coot/dmq-node-to-node branch 2 times, most recently from a1a6dd4 to b35f1eb Compare September 9, 2025 12:15
coot
coot approved these changes Sep 9, 2025
View reviewed changes
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/coot/dmq-node-to-node branch from b35f1eb to 41c0634 Compare September 9, 2025 13:47
@coot coot mentioned this pull request Sep 9, 2025
Merged
7 tasks
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/coot/dmq-node-to-node branch 2 times, most recently from 0eb4e3e to 6b99a62 Compare September 9, 2025 16:45
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/coot/dmq-node-to-node branch from 6b99a62 to 2805796 Compare September 10, 2025 07:41
@coot coot enabled auto-merge September 10, 2025 08:29
@coot coot added this pull request to the merge queue Sep 10, 2025
Merged via the queue into main with commit 4d15509 Sep 10, 2025
12 checks passed
@coot coot deleted the mwojtowicz/coot/dmq-node-to-node branch September 10, 2025 12:37
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ouroboros Network Sep 10, 2025
@coot coot added the mithril Things related to Mithril. label Sep 10, 2025
@coot coot linked an issue Sep 10, 2025 that may be closed by this pull request
Implement N2C mini-protocol applications #5179
Closed
2 tasks
@coot coot mentioned this pull request Sep 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coot coot coot approved these changes

Assignees

@crocodile-dentist crocodile-dentist

Labels

dmq-node Issues / PRs related to DMQ Node mithril Things related to Mithril.

Projects

Ouroboros Network
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement N2C mini-protocol applications Implement N2C mithril mini-protocols

3 participants

@crocodile-dentist @coot