dmq: using annotated codec and OCert from kes-agent library #5195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/dmq-cip-137-update
branch
from
17e61f1 to
bf98713
Compare
coot
force-pushed
the
coot/dmq-cip-137-update
branch
13 times, most recently
from
14f8088 to
27e37c9
Compare
For `SigSubmission` protocol, we need a decoder which can retain bytes of a substructure.
`anncodecTxSubmission2'`: * use `rawTx` and `tx` rather than a `tx` and `withBytes tx`. This allows one to use custom types or a `WithBytes` functor. * use a smart constructor for `tx`-s of type `ByteString -> rawTx -> tx` rather than one that requires to manipulate `ByteString` given the offsets. * Export `encodeBytes`. `anncodecTxSubmission2` is preserved without any modifications.
For `dmq-node` we need a `local-tx-submission` codec which retains bytes received from network (e.g. an annotated codec).
Use `Sig` data type which contains bytes: rather than using `WithBytes SigRaw`, we use `Sig` data type which contains bytes of the signature. This is possible thanks to changes in the previous commit.
* signed fields of Sig include: `sigRawId`, `sigRawBody`, `sigRawKESPeriod`, `sigRawExpiresAt`. * added `SigRawWithSignedBytes`, which carries signed bytes by the KES key.
We need to use since in the initial version of `dmq-node` because of its own CBOR encoding. It is not cryptographically checked.
Depend on version of `kes-agent` which doesn't require `git` or `date` from being available in the PATH.
coot
force-pushed
the
coot/dmq-cip-137-update
branch
from
27e37c9 to
a97f15c
Compare
This fixes a circular dependency between `kes-agent` and `ouroboros-network` packages which breaks the usage of `cabal build --dpenendencies-only` in GHA.
* Make all `TxLogic` appear under `AppV2` group. * Renamed `AppV2.diffusion` test as `AppV2.txSubmission` similar to `AppV2.txSubmission` This makes it easier to run all tx-submission v2 tests.
coot
force-pushed
the
coot/dmq-cip-137-update
branch
from
a97f15c to
fbf2875
Compare
crocodile-dentist
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dependencies
Patches
kes-agent-cryptolibrarykes-agentChecklist
Quality
Maintenance
ouroboros-networkproject.