Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a wallet causes the actions to disappear #824

Closed
j-mueller opened this issue Apr 3, 2019 · 1 comment
Closed

Removing a wallet causes the actions to disappear #824

j-mueller opened this issue Apr 3, 2019 · 1 comment
Assignees
Labels

Comments

@j-mueller
Copy link
Contributor

To reproduce

  1. load gist accd2826d83e7ce345f8417c06cb7cdd
  2. In the "Simulation" tab, remove wallet 3
  3. All actions disappear
@krisajenkins
Copy link
Contributor

Whilst this was deliberate....I have been persuaded it's not as great an idea as it seemed at the time. :-D

My thinking was that once you remove a wallet, you can invalidate the simulations, and there's no way in general we can know which actions are now invalid.

However, killing all the simulations is a bit of a, "sledgehammer to crack a walnut," solution, I admit.

I'm going to change this so that the user will have to delete/amend affected actions. They've always been able to submit invalid scenarios, and always been given appropriate feedback when they do.

@krisajenkins krisajenkins self-assigned this Apr 4, 2019
krisajenkins added a commit that referenced this issue Apr 4, 2019
…ck when an action relates to a deleted wallet.
krisajenkins added a commit that referenced this issue Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants