Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playground: Fix #824. #832

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Playground: Fix #824. #832

merged 2 commits into from
Apr 4, 2019

Conversation

krisajenkins
Copy link
Contributor

No description provided.

@krisajenkins
Copy link
Contributor Author

Fixing #824. Deleting a wallet no longer deletes the actions, but does give you a little visual feedback:

Screenshot 2019-04-04 at 12 02 53

@krisajenkins
Copy link
Contributor Author

cc @pkellyiohk.

shmish111
shmish111 approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@shmish111 shmish111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM as long as the experience is deemed correct

@krisajenkins
Copy link
Contributor Author

The thumbs ups on #824 tell me people are happy/happier with this UX. :-)

@krisajenkins krisajenkins merged commit 1397cc9 into master Apr 4, 2019
@krisajenkins krisajenkins deleted the issue-824 branch April 4, 2019 11:50
@rmourey26 rmourey26 mentioned this pull request Nov 5, 2022
Open
@rmourey26 rmourey26 mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmish111 shmish111 shmish111 approved these changes

@j-mueller j-mueller Awaiting requested review from j-mueller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krisajenkins @shmish111