#185: Fixed missed scenarios for BDD #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grey-rain
changed the title
Invictum
previously approved these changes
Aug 30, 2024
| TestType testType = TestType.byTestSource(testOutcome.getTestSource()); | ||
| if (testType == TestType.BDD) { | ||
| testFinished(testOutcome); | ||
| } |
There was a problem hiding this comment.
- This might be dangerous without extensive testing of all supported bdd style tests.
- Might worths to add a unit test for this logic.
Invictum
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#185
Cause
It seems like call order for listeners of different types has been changed.
Current fix is implemented only for BDD Scenarios (since we've got a request), however, other types of tests also have issues reporting their Failed results.
Issues in other test types results will be addressed separately.