Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#185: Fixed missed scenarios for BDD #189

Merged
merged 4 commits into from
Aug 30, 2024
Merged

#185: Fixed missed scenarios for BDD #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7a335b
Fixed missed scenarios for BDD
grey-rain Aug 29, 2024
0292570
Updated the version for the release
grey-rain Aug 30, 2024
7e235c4
Reverted version to the actual
grey-rain Aug 30, 2024
ae9a2b4
Fixes according to comments
grey-rain Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<groupId>com.github.invictum</groupId>
<artifactId>serenity-reportportal-integration</artifactId>
<version>1.6.0-SNAPSHOT</version>
<version>1.6.2-SNAPSHOT</version>

<packaging>jar</packaging>

Expand All @@ -26,6 +26,11 @@
<email>zim182@gmail.com</email>
<organizationUrl>https://github.com/Invictum</organizationUrl>
</developer>
<developer>
<name>Daria Yershova</name>
<email>dariayershova@icloud.com</email>
<organizationUrl>https://github.com/grey-rain</organizationUrl>
</developer>
</developers>

<scm>
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/com/github/invictum/reportportal/ReportPortalListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,9 @@ public void stepFinished(List<ScreenshotAndHtmlSource> list, ZonedDateTime zoned

@Override
public void testFailed(TestOutcome testOutcome, Throwable throwable) {
// Not used by listener
if (testOutcome.getTestSource().toLowerCase().contains("cucumber")) {
testFinished(testOutcome);
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This might be dangerous without extensive testing of all supported bdd style tests.
  2. Might worths to add a unit test for this logic.

}

@Override
Expand Down
Loading