Skip to content

Commit

Permalink
Hotfix: change role="button" to type="button"
Browse files Browse the repository at this point in the history
* Closes issue #45 and properly fixes issue #38
* Added typescript support line to README
* Bumped version to 2.5.1
* Rebuilt dist files
  • Loading branch information
Ionaru committed Jan 17, 2019
1 parent 8c6ae58 commit 20cd3e4
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Changes include:
* Support for Node 8 and beyond
* Lots of refactored code
* Links in preview will open in a new tab by default
* Typescript support

My intention is to continue development on this project, improving it and keeping it alive.

Expand Down
2 changes: 1 addition & 1 deletion dist/easymde.min.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions dist/easymde.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "easymde",
"version": "2.5.0",
"version": "2.5.1",
"description": "A simple, beautiful, and embeddable JavaScript Markdown editor that easy to use. Features include autosaving and spell checking.",
"keywords": [
"embeddable",
Expand Down
2 changes: 1 addition & 1 deletion src/js/easymde.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ function createIcon(options, enableTooltips, shortcuts) {
options = options || {};
var el = document.createElement('button');
el.className = options.name;
el.setAttribute('role', 'button');
el.setAttribute('type', 'button');
enableTooltips = (enableTooltips == undefined) ? true : enableTooltips;

if (options.title && enableTooltips) {
Expand Down

0 comments on commit 20cd3e4

Please sign in to comment.