Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type="button" to toolbar buttons #38

Closed
1 of 2 tasks
MichalRemis opened this issue Dec 19, 2018 · 1 comment
Closed
1 of 2 tasks

Add type="button" to toolbar buttons #38

MichalRemis opened this issue Dec 19, 2018 · 1 comment
Labels
Bug

Comments

@MichalRemis
Copy link

MichalRemis commented Dec 19, 2018 •
edited
Loading

I'm submitting a...

  • Bug report
  • Feature request

Reproduction steps

Please add role="button" to toolbar buttons. Otherwise they are by default treated as submit buttons which causes weird behaviour when SimpleMDE is inside a form with other inputs. Instead of submitting the form when I press <enter>, first button (SimpleMDE's bold button) is pressed.

See this fiddle: https://jsfiddle.net/ge9hfkaL/2/

Version information

Browser type and version: all?
EasyMDE version: all?
@Ionaru Ionaru added the Bug label Dec 19, 2018
@Ionaru Ionaru closed this as completed in b31c0a1 Jan 17, 2019
@MichalRemis MichalRemis changed the title Add role="button" to toolbar buttons Add type="button" to toolbar buttons Jan 17, 2019
@MichalRemis
Copy link
Author

I am sorry I tested your release and this bug and it is still ocurring. I googled again and tested it, and the correct attribute to make it work is type="button" not role.

@MichalRemis MichalRemis mentioned this issue Jan 17, 2019
Closed
Ionaru added a commit that referenced this issue Jan 17, 2019
@Ionaru
Hotfix: change role="button" to type="button"
20cd3e4 
* Closes issue #45 and properly fixes issue #38
* Added typescript support line to README
* Bumped version to 2.5.1
* Rebuilt dist files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichalRemis @Ionaru