Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address registration tests #3859

Closed
shaun-technovation opened this issue Feb 16, 2023 · 2 comments
Closed

Address registration tests #3859

shaun-technovation opened this issue Feb 16, 2023 · 2 comments
Assignees
Labels

Comments

@shaun-technovation
Copy link
Contributor

shaun-technovation commented Feb 16, 2023

The following tests should be updated/fixed, or removed:


Students signing up location form lets you change its guess
  # Temporarily skipped with xdescribe
  # ./spec/system/student/signup_spec.rb:52

Students signing up authenticating logs in okay with the email / password used during signup
  # Temporarily skipped with xdescribe
  # ./spec/system/student/signup_spec.rb:5

Activate your email to sign up Register the signup attempt on sign up
  # Temporarily disabled with xfeature
  # ./spec/features/activate_email_for_signup_spec.rb:27

Activate your email to sign up Activate your email for signing up
  # Temporarily disabled with xfeature
  # ./spec/features/activate_email_for_signup_spec.rb:6

Student team submissions See live pitch event submission pieces on TOC
  # Temporarily disabled with xscenario
  # ./spec/features/mentor/submission_spec.rb:157

Mentors signing up authenticating logs in okay with the email / password used during signup
  # Temporarily skipped with xdescribe
  # ./spec/system/mentor/signup_spec.rb:5
@shaun-technovation shaun-technovation self-assigned this Sep 19, 2023
shaun-technovation added a commit that referenced this issue Sep 19, 2023
We aren't using the old signup flow anymore, so this specs aren't needed
now.

Refs: #3859
shaun-technovation added a commit that referenced this issue Sep 19, 2023
These specs are related to the old "signup attempt" functionality which
we're not using anymore, so I'm removing the related specs.

Refs: #3859
shaun-technovation added a commit that referenced this issue Sep 19, 2023
We aren't using the old signup flow anymore, so this specs aren't needed
now.

Refs: #3859
@shaun-technovation
Copy link
Contributor Author

For the "signup" and "signup flow" related specs, I removed those since neither of those things are being used now.

And one non-signup test made it into this issue:

./spec/features/mentor/submission_spec.rb:157

I moved that one into #3851.

shaun-technovation added a commit that referenced this issue Sep 20, 2023
We aren't using the old signup flow anymore, so this specs aren't needed
now.

Refs: #3859
shaun-technovation added a commit that referenced this issue Sep 20, 2023
These specs are related to the old "signup attempt" functionality which
we're not using anymore, so I'm removing the related specs.

Refs: #3859
shaun-technovation added a commit that referenced this issue Sep 20, 2023
We aren't using the old signup flow anymore, so this specs aren't needed
now.

Refs: #3859
@shaun-technovation
Copy link
Contributor Author

Moving this one to "Ready to Deploy" since there is nothing to test for this one. 👍

shaun-technovation added a commit that referenced this issue Sep 20, 2023
We aren't using the old signup flow anymore, so this specs aren't needed
now.

Refs: #3859
shaun-technovation added a commit that referenced this issue Sep 20, 2023
These specs are related to the old "signup attempt" functionality which
we're not using anymore, so I'm removing the related specs.

Refs: #3859
shaun-technovation added a commit that referenced this issue Sep 20, 2023
We aren't using the old signup flow anymore, so this specs aren't needed
now.

Refs: #3859
@dboyer dboyer closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants