Hand Rendering

[maximumpower55]

closes: #349

[Kichura]

mc.mp4

Seems to be working properly in some places but with other shaders, it causes items to be transparent or hand becomes uglified from reflections. otherwise not bad.

[coderbot16]

@Kichura what exactly is the context of the video? The whole world turning black a few seconds in seems like a pretty critical issue

[IMS212]

Doesn't seem like you're accounting for non-70 FOV's.

[IMS212]

It also seems to clip through blocks

[Kichura]

@Kichura what exactly is the context of the video? The whole world turning black a few seconds in seems like a pretty critical issue

The fading is from continuum itself and i did not make the changes to it, might have to look through the config. - as for video, was trying to show that hand's lighting exposure is working properly when aiming at a specific angle unlike everything. (changing camera angle makes hand look uglified)

edit: caused by "camera mode" when set to auto, meaning it's intended.

[maximumpower55]

Converting this to draft and starting to work on fixing the major issues

[maximumpower55]

Fixed Most Major issues

this is some screenshots of it using Complementary v4.2.1

[IMS212]

Can you test Sildur's just to make sure

[maximumpower55]

Sure one second

[maximumpower55]

For some reason everything is black on sildurs vibrant medium

Can you test it on normal iris to make sure its not a issue with iris it self

[IMS212]

It's not, I had the same issue when previously attempting hand rendering which made me stop working on it. Not sure what's up with it.

[maximumpower55]

More Debugging for me i guess

[maximumpower55]

Looks like its a issue with the way i fixed the clipping issues

Im going to try to find a other way to fix them

[maximumpower55]

Cant find a way to fix it

Im going to make this ready for review

If this gets merged

[maximumpower55]

Through out testing with other shaderpacks this is my collection of issues

Complementary 4.2.1 works with out any issues
Continuum 2.0.4 works with some issues mainly the clouds move with the camera
BSL 8.1.01 works with out any issues
Oceano 3.0.1 is broken
SEUS Renewed 1.0.1 the shadows are broken and the hand is transparent and there is a weird white overlay over the screen
Every Version of Sidurs Vibrant Shaders is broken everything is black but the water

[maximumpower55]

@coderbot16 how is this looking for you

[coderbot16]

I'm pretty sure clearing the depth buffer is going to cause a lot of chaos. I'll try to figure out how ShadersMod handled hand clipping.

[maximumpower55]

ok

[maximumpower55]

give me all the feedback you have because im a first time contributor to iris

[Kichura]

Tested complementary here with a gold sword and now it looks worse than before, BSL however doesn't seem to show this issue here.

[maximumpower55]

@Kichura what version of complementary

[Kichura]

@Kichura what version of complementary

v4.2.1 without modifications applied.

[coderbot16]

This is looking much nicer now, good work. I still have some things that I'd like resolved but it's definitely possible this could make it in to the next release.

[coderbot16]

Once MixinItemBlockRenderTypes is addressed this should be ready for merge.

[coderbot16]

Thanks! The lack of hand rendering is one of the bigger issues affecting Complementary Shaders. I wasn't looking forward to implementing this myself, so it's great that you both took it on. Looking forward to shipping it in the next update!