Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #74

Merged
merged 17 commits into from
Dec 6, 2021
Merged

Upgrade dependencies #74

merged 17 commits into from
Dec 6, 2021

Conversation

giarc3
Copy link
Member

@giarc3 giarc3 commented Dec 2, 2021

Daily builds of this repo just started failing. I think this is because the GitHub Actions runners recently moved to Node 16, which isn't shown as supported by our current version of neon/neon-build. This is an attempt to upgrade everything to latest and see if CI passes (I couldn't reproduce the error locally).

@giarc3 giarc3 requested a review from a team as a code owner December 2, 2021 16:36
@giarc3 giarc3 requested review from skeet70 and removed request for a team December 2, 2021 16:36
@giarc3 giarc3 requested a review from a team as a code owner December 2, 2021 16:41
@giarc3 giarc3 requested review from cjyar and removed request for a team December 2, 2021 16:41
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

No changes to code coverage between the base branch and the head branch

@IronCoreLabs IronCoreLabs deleted a comment from github-actions bot Dec 2, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

No changes to code coverage between the base branch and the head branch

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

No changes to code coverage between the base branch and the head branch

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

No changes to code coverage between the base branch and the head branch

@giarc3
Copy link
Member Author

giarc3 commented Dec 3, 2021

The test that's failing (TypeScript CI / test (16, stable, ubuntu-20.04) (pull_request)) is the test that compares coverage with this branch against main. This will fail on this PR because the version of the neon dependency on main is incompatible with Node 16.
I think we're good to merge even though this is failing, but an alternative is to make the Node 14 matrix run do coverage instead.

@skeet70 @leeroy-travis
Neon packaging (#75)
2c40cf1 
Removed the native directory. Made the tests run expecting the same
structure as what we distribute. That same structure is created by
either running `yarn compile` or `node-pre-gyp install` (the second
being how and end user gets the binary).

The publish structure is the same other than the new entry point, so
that should continue working.

* Add NAPI to changelog, would be good to remember

* bump-version: Set release version 0.8.0-pre.1

* Add a comment to clarify where changes happen

Limited jest `maxWorkers` to dodge the weird GH issue tracked by
jestjs/jest#10662 but won't impact local
machine runs as much

Co-authored-by: Leeroy Travis <ops@ironcorelabs.com>
@skeet70
Copy link
Member

skeet70 commented Dec 6, 2021

In addition to the failure due to coverage that @giarc3 mentioned, the intermittent failure on node 12 builds seems to be a bug related to Jest in GH actions specifically. We've tried to reproduce:

  • locally on Arch (w/12,14,16)
  • locally on Ubuntu focal w/12
  • docker on Ubuntu focal w/12,14,16

and haven't been able to. The only place it fails is in GH actions, and for us so far only with Node 12.

We're going to try merging this and see if we can get release builds working through the intermittent failures or not.

Likely Tracking Issues:
nodejs/node#40058
jestjs/jest#10662

@skeet70 skeet70 merged commit fbb07eb into main Dec 6, 2021
@skeet70 skeet70 deleted the dep-updates branch December 6, 2021 21:00
trivikr added a commit to trivikr/aws-sdk-js-v3 that referenced this pull request Jan 6, 2022
@trivikr
fix(package.json): attempt running jest with 50% of maxWorkers
99bd32b 
Refs: IronCoreLabs/recrypt-node-binding#74 (comment)
@skeet70 skeet70 mentioned this pull request Jan 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyar cjyar cjyar approved these changes

@skeet70 skeet70 Awaiting requested review from skeet70 skeet70 is a code owner automatically assigned from IronCoreLabs/js-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giarc3 @skeet70 @cjyar