Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neon packaging #75

Merged
merged 12 commits into from
Dec 6, 2021
Merged

Neon packaging #75

merged 12 commits into from
Dec 6, 2021

Conversation

skeet70
Copy link
Member

@skeet70 skeet70 commented Dec 6, 2021

Moves to the new neon build process, removes now dead dependencies and publish steps. Makes sure that what we test is as close as possible to what gets distributed.

Removed the native directory. Made the tests run expecting the same
structure as what we distribute. That same structure is created by
either running `yarn compile` or `node-pre-gyp install` (the second
being how and end user gets the binary).

The publish structure is the same other than the new entry point, so
that should continue working.
@skeet70 skeet70 requested a review from giarc3 December 6, 2021 19:13
@skeet70 skeet70 requested review from a team as code owners December 6, 2021 19:13
@skeet70 skeet70 requested review from coltfred and cjyar and removed request for a team December 6, 2021 19:13
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

No changes to code coverage between the base branch and the head branch

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

No changes to code coverage between the base branch and the head branch

@skeet70
Copy link
Member Author

skeet70 commented Dec 6, 2021

I additionally tested this by linking the result after a yarn compile to ironnode and running all the tests there. Once this all merges, we should run the same test with the pre version that will be published to npm by default. If that works, then we can run bump version on main to release 0.8.0

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

No changes to code coverage between the base branch and the head branch

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

No changes to code coverage between the base branch and the head branch

Should still dodge the weird GH issue tracked by
jestjs/jest#10662 but won't impact local
machine runs as much
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

No changes to code coverage between the base branch and the head branch

@skeet70 skeet70 merged commit 2c40cf1 into dep-updates Dec 6, 2021
@skeet70 skeet70 deleted the neon-packaging branch December 6, 2021 20:38
skeet70 added a commit that referenced this pull request Dec 6, 2021
* Update to latest of all deps

* Recrypt 0.12

* Try Node 16 as well

* Reduce cardinality

* Bump MSRV to 1.51

* Update documentation.

* Upgrade JS dependencies too.

* Replace Node 10 with 16 in the matrix

* Apply patch

* Update recrypt

* And changelog

* Rust 2021 so we can use recrypt 0.13

* Checkpointing migration to NAPI

* Try different coverage switch command

* Rust fmt

* Neon packaging (#75)

Removed the native directory. Made the tests run expecting the same
structure as what we distribute. That same structure is created by
either running `yarn compile` or `node-pre-gyp install` (the second
being how and end user gets the binary).

The publish structure is the same other than the new entry point, so
that should continue working.

* Add NAPI to changelog, would be good to remember

* bump-version: Set release version 0.8.0-pre.1

* Add a comment to clarify where changes happen

Limited jest `maxWorkers` to dodge the weird GH issue tracked by
jestjs/jest#10662 but won't impact local
machine runs as much

Co-authored-by: Leeroy Travis <ops@ironcorelabs.com>

Co-authored-by: Murph Murphy <murph@clurictec.com>
Co-authored-by: Leeroy Travis <ops@ironcorelabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants