Remove HttpResolver url prefix #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannylamb
reviewed
Aug 27, 2019
| @@ -63,4 +63,4 @@ cantaloupe_cache_source: FilesystemCache | |||
| cantaloupe_cache_derivative: FilesystemCache | |||
| cantaloupe_create_FilesystemCache_dir: yes | |||
| cantaloupe_resolver_static: HttpResolver | |||
| cantaloupe_HttpResolver_BasicLookupStrategy_url_prefix: "http://{{ hostvars[groups['webserver'][0]].ansible_host }}:{{ apache_listen_port }}/" | |||
| cantaloupe_HttpResolver_BasicLookupStrategy_url_prefix: "" | |||
There was a problem hiding this comment.
Yes, to override the default from the role.
https://github.com/Islandora-Devops/ansible-role-cantaloupe/blob/master/defaults/main.yml#L167
|
|
dannylamb
approved these changes
Aug 30, 2019
There was a problem hiding this comment.
Tested with Islandora/openseadragon#13 and we're good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1226 and possibly Islandora/documentation#1121
Other Relevant Links
What does this Pull Request do?
Removes the HttpResolver url prefix. We will send the entire URL now.
What's new?
(ie. Regeneration activity, etc.)? no
How should this be tested?
See associated PR for testing instructions.
A description of what steps someone could take to:
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
@Islandora-Devops/committers