Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the full URI to IIIF server #13

Merged
merged 4 commits into from
Aug 30, 2019
Merged

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Aug 26, 2019

GitHub Issue: Islandora/documentation#1226
This possibly also resolves Islandora/documentation#1121

Other Relevant Links

What does this Pull Request do?

Stops stripping the base URI off the file to be passed to Cantaloupe.

What's new?

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository
    (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

  1. Enable a second language in your Islandora 8 site.
  2. Make a large image with a Tiff.
  3. Translate the node.
  4. View the original English, see the Openseadragon viewer work.
  5. View the translated version, see the Openseadragon view display an error.
  6. Pull this PR in on top of your openseadragon module.
  7. Go edit (assuming claw-playbook) sudo vim /opt/cantaloupe/cantaloupe.properties
  8. Find the line HttpResolver.BasicLookupStrategy.url_prefix = http://localhost:8000/
  9. Change it to HttpResolver.BasicLookupStrategy.url_prefix =
  10. Save and close cantaloupe.properties
  11. Clear Drupal cache.
  12. View the translated node again

See the image!

Interested parties

@Islandora-CLAW/committers @Natkeeran @rangel35

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success. I can translate an image and have it render with openseadragon.

Screenshot from 2019-08-30 10-52-14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openseadragon adding additional information into url with languages other than english
2 participants