specify alpaca_karaf_repos to include 1.0.2 of alpaca #146
Conversation
|
That should work @elizoller, but I can't seem to get a server up for reasons totally unrelated to this pull. Ever since I updated to Ubuntu 18.04 everything's a mess.... |
| alpaca_karaf_repos: | ||
| - mvn:org.apache.camel.karaf/apache-camel/2.20.4/xml/features | ||
| - mvn:org.apache.activemq/activemq-karaf/5.15.0/xml/features | ||
| - mvn:ca.islandora.alpaca/islandora-karaf/1.0.2/xml/features |
There was a problem hiding this comment.
There is no 1.0.2 version of Alpaca.
https://search.maven.org/artifact/ca.islandora.alpaca/islandora-karaf
There was a problem hiding this comment.
I was going off this: https://github.com/Islandora/Alpaca/blob/dev/gradle.properties
There was a problem hiding this comment.
We're building it from source now in dev. This is to make it work that way. We could also just slice a 1.0.2 release and do it that way.
There was a problem hiding this comment.
For what it's worth, I did test a build with this PR and successfully built Alpaca from dev and installed the features. Without this PR, even with telling it to build from dev, it only installs the 1.0.1 version of Alpaca so it is missing the versioning components and breaks the sending of content to Fedora.
There was a problem hiding this comment.
That should probably be looked at in the ansible-role-alpaca then, it must not be working as expected. Probably some ansible version issue.
There was a problem hiding this comment.
Am I reading this wrong? It looks like to me that the ansible-role-alpaca includes the compile.yml task when the ansible_from_source is true but in compile.yml (https://github.com/Islandora-Devops/ansible-role-alpaca/blob/master/tasks/compile.yml#L26) it doesn't appear to be doing a gradle clean build install but rather just an install. My knowledge of gradle is limited but I'm guessing we at least need the build part if we're building from dev rather than an existing version?
There was a problem hiding this comment.
Clean is only needed if you built if before, so as we (should) only build it once the clean is redundant.
But after some digging I see why you need this. We will need to watch and ensure that as the version of alpaca in dev moves up so does this variable.
I'm going to pull this in and rebuild my vagrant.
There was a problem hiding this comment.
and unfortunately alpaca_version can be a branch name, so it's not like we can put it in the repo url to keep things in sync :(
There was a problem hiding this comment.
👍 This does resolve the problem.
We just need to be aware that these repos will need to be updated when we update the Alpaca gradle.properties file.
https://github.com/Islandora/Alpaca/blob/dev/gradle.properties#L1
|
Just remembered I need to test build with Centos before merging |
What does this Pull Request do?
Tells the ansible-role-alpaca to use version 1.0.2 of Alpaca
What's new?
A change in the karaf.yml for inventory/vagrant/group_vars that overrides the defaults for ansible_karaf_repos in the ansible-role-alpaca
How should this be tested?
Interested parties
@Islandora-Devops/committers