Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify alpaca_karaf_repos to include 1.0.2 of alpaca #146

Merged
merged 1 commit into from
Dec 4, 2019
Merged

specify alpaca_karaf_repos to include 1.0.2 of alpaca #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions inventory/vagrant/group_vars/karaf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
alpaca_from_source: yes
alpaca_version: dev
alpaca_clone_directory: /opt/alpaca
alpaca_karaf_repos:
- mvn:org.apache.camel.karaf/apache-camel/2.20.4/xml/features
- mvn:org.apache.activemq/activemq-karaf/5.15.0/xml/features
- mvn:ca.islandora.alpaca/islandora-karaf/1.0.2/xml/features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no 1.0.2 version of Alpaca.
https://search.maven.org/artifact/ca.islandora.alpaca/islandora-karaf

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going off this: https://github.com/Islandora/Alpaca/blob/dev/gradle.properties

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're building it from source now in dev. This is to make it work that way. We could also just slice a 1.0.2 release and do it that way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, I did test a build with this PR and successfully built Alpaca from dev and installed the features. Without this PR, even with telling it to build from dev, it only installs the 1.0.1 version of Alpaca so it is missing the versioning components and breaks the sending of content to Fedora.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should probably be looked at in the ansible-role-alpaca then, it must not be working as expected. Probably some ansible version issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I reading this wrong? It looks like to me that the ansible-role-alpaca includes the compile.yml task when the ansible_from_source is true but in compile.yml (https://github.com/Islandora-Devops/ansible-role-alpaca/blob/master/tasks/compile.yml#L26) it doesn't appear to be doing a gradle clean build install but rather just an install. My knowledge of gradle is limited but I'm guessing we at least need the build part if we're building from dev rather than an existing version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean is only needed if you built if before, so as we (should) only build it once the clean is redundant.

But after some digging I see why you need this. We will need to watch and ensure that as the version of alpaca in dev moves up so does this variable.

I'm going to pull this in and rebuild my vagrant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and unfortunately alpaca_version can be a branch name, so it's not like we can put it in the repo url to keep things in sync :(


triplestore_namespace: islandora
alpaca_triplestore_base_url: "http://{{ hostvars[groups['tomcat'][0]].ansible_host }}:8080/bigdata"
Expand Down