Correct namespace for tests #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restrict symfony versions Fix deprecation in test
This was referenced Apr 8, 2020
|
@whikloj are you still waiting on someone to help out with this? |
|
@rosiel yes, if there is still a desire to transition from Flex to Symfony. |
|
@whikloj i can give a shot at testing this - would this be the first PR in the sequence? |
|
I believe so yes. Not that anyone uses the playbook anymore but this (Islandora-Devops/islandora-playbook#175) pulled in all individual branches. |
|
To test this I did the following:
|
elizoller
approved these changes
Dec 29, 2020
whikloj
added a commit
that referenced
this pull request
Oct 29, 2021
Restrict symfony versions Fix deprecation in test
adam-vessey
pushed a commit
that referenced
this pull request
May 5, 2022
* Change to symfony/flex * Coder * Correct namespace for tests (#39) Restrict symfony versions Fix deprecation in test * Finalize Crayfish-Commons in Symfony 4.4 * Don't fail if no Apix-Ldp-Resource header * Remove check for master request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1224
** DO NOT MERGE FIRST **
The sequence for the related PRs is
What does this Pull Request do?
This really does nothing other than update the symfony version and composer packages, fix the tests namespaces for autoload and a change in how a ClientException is constructed.
How should this be tested?
This is used as part of above PRs, if that passes then this could be merged.
Interested parties
@Islandora/8-x-committers