Make Crayfish-Commons a Symfony bundle only. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restrict symfony versions Fix deprecation in test
This was referenced Nov 3, 2021
adam-vessey
reviewed
Dec 10, 2021
ruebot
approved these changes
Apr 26, 2022
Closed
adam-vessey
reviewed
Oct 18, 2022
Comment on lines
-50
to
+65
| return new Response( | ||
| "Malformed request, no Apix-Ldp-Resource header present", | ||
| 400 | ||
| ); | ||
| $this->log->debug("No Apix-Ldp-Resource header present, no fedora_resource set"); | ||
| $request->attributes->set('fedora_resource', false); | ||
| return; |
There was a problem hiding this comment.
In poking around and running tests, I found that the we broke the tests here, where it tests for the 400 error being emitted... easy enough fix just setting the response with something like:
diff --git a/ApixMiddleware.php b/ApixMiddleware.php
index b75df0a..5a29209 100644
--- a/ApixMiddleware.php
+++ b/ApixMiddleware.php
@@ -62,6 +62,10 @@ class ApixMiddleware implements EventSubscriberInterface
if (!$request->headers->has("Apix-Ldp-Resource")) {
$this->log->debug("No Apix-Ldp-Resource header present, no fedora_resource set");
$request->attributes->set('fedora_resource', false);
+ $event->setResponse(new Response(
+ "Malformed request, no Apix-Ldp-Resource header present",
+ 400
+ ));
return;
}
There was a problem hiding this comment.
Looking to address in #57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1224
What does this Pull Request do?
Updates Crayfish-Commons to make it a Symfony 4.4 LTS bundle fully.
This PR goes along with an upcoming one for Crayfish that changes ALL the microservices to Symfony 4.4.
This PR moves the stuff that has been sitting in the symfony-flex branch (for Houdini) and makes it the actual Crayfish-Commons code as ALL microservices will be using symfony.
As this is not backwards compatible with Crayfish-Commons 2.0.0, this PR is against the new 3.x branch and will be the first commit of version 3.0.0
Once this PR and the Crayfish PR are merged, the branch
symfony-flexcan be deleted.What's new?
How should this be tested?
This will need to be tested with the associated PR in Crayfish Islandora/Crayfish#133
Additional Notes:
Interested parties
@Islandora/8-x-committers