Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the response as expected by the test. #57

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

adam-vessey
Copy link
Contributor

@adam-vessey adam-vessey commented Oct 19, 2022

Islandora\Crayfish\Commons\Tests\ApixMiddlewareTest::testReturns400IfNoApixLdpResourceHeader() expects an HTTP 400 to be emitted; however, it was not being done.

What does this Pull Request do?

Restores behaviour being tested that was changed in the move to Symfony bundles

  • Related GitHub Issue: (link)

  • Other Relevant Links: (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What's new?

A in-depth description of the changes made by this PR. Technical details and
possible side effects.

  • Changes x feature to such that y
  • Added x
  • Removed y
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)?
  • Could this change impact execution of existing code?

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the Pull Request does what is intended.
  • Please be as detailed as possible.
  • Good testing instructions help get your PR completed faster.

Documentation Status

  • Does this change existing behaviour that's currently documented?
  • Does this change require new pages or sections of documentation?
  • Who does this need to be documented for?
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

Islandora\Crayfish\Commons\Tests\ApixMiddlewareTest::testReturns400IfNoApixLdpResourceHeader()
expects an HTTP 400 to be emitted; however, it was not so.
@adam-vessey adam-vessey marked this pull request as ready for review October 19, 2022 16:37
@alxp alxp merged commit 64f0c7c into Islandora:3.x Oct 19, 2022
@adam-vessey adam-vessey deleted the fix/response-when-absent branch October 11, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants