Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text extraction #7

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Text extraction #7

merged 2 commits into from
Sep 19, 2019

Conversation

dannylamb
Copy link
Contributor

GitHub Issue: Islandora/documentation#933

Works with:

What does this Pull Request do?

Config to trigger OCR derivatives using islandora_text_extraction

What's new?

Re-worked contexts and moves the field storage for the 'weight' field over to islandora_core_feature.

How should this be tested?

Test PR coming soon

Interested parties

@Islandora-CLAW/committers @dbernstein @ajstanley

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UUIDs should be removed.

config/install/context.context.pages.yml Outdated Show resolved Hide resolved
config/install/context.context.pages.yml Outdated Show resolved Hide resolved
@dannylamb
Copy link
Contributor Author

@seth-shaw-unlv Ok, I squashed all my previous commits into one and then tacked the UUID removal commit afterwards. When merging, please do not squash and merge so that last commit can be reverted separately in case something blows up when testing with a re-provision. Everything will probably be fine, but I'm paranoid like that.

@dannylamb
Copy link
Contributor Author

dannylamb commented Sep 19, 2019

FYI I used this command to destroy the UUIDs:

$ sed -i '/uuid:/d' config/install/*.yml

That's for GNU sed. If you're using BSD sed (e.g. Mac), I think it's

$ sed -i '' '/uuid:/d' config/install/*.yml

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@seth-shaw-unlv
Copy link
Contributor

Don't know why Travis couldn't find the storage config for field_weight in islandora_core_feature... it is there...

@seth-shaw-unlv seth-shaw-unlv merged commit 3e132f9 into 8.x-1.x Sep 19, 2019
@seth-shaw-unlv seth-shaw-unlv deleted the text_extraction branch September 19, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants