ISLANDORA-2116 adjusted newspaper display to only load first year iss…

[wgilling]

…ues, also added ajax handler to populate for any year clicked

JIRA Ticket: (link)
https://jira.duraspace.org/browse/ISLANDORA-2116

What does this Pull Request do?

This will change the newspaper view so that only the first year's issues are loaded into the web browser -- and all clicks to other years are handled by an AJAX call.

What's new?

This also adds a thumbnail to the view area and automatically expands the loaded fieldsets so that they are not collapsed by default - which may not be desired by some, but our usability study has asked why they were collapsed (I could remove that modification from this pull request).

This would change what gets indexed by search engines for the initial load of the page.

How should this be tested?

A thorough test would be to:

1. (before merging this code), load a newspaper into the browser that has more than one year of issues and preferably thousands of issues. Inspect the load time for this web page.
2. Install the updated code here and clear the drupal cache. Repeat step 1 to see how the load time should be much quicker with far fewer requests (only the first year should be loaded into the browser initially).
3. ensure that each year can be clicked and loaded into the right side of the screen where the issues are displayed.

Additional Notes:

As I do not see any specific documentation relative to the newspaper viewer, there probably isn't any need to change the wiki documentation.

[whikloj]

Nice work @bgilling, I'm going to pull this down and play with it. We probably (though I'm not sure) want to allow people to turn on with an admin option.
@mjordan you might want to check this out too.

[whikloj]

So this works, but it adds in the thumbnail stuff. I'll see if I can switch it back to the default display and then test it on our dev server and possibly on our backend production server.

[wgilling]

Drats -- I can replace this commit with one that does not have the thumbs... gimme 15 mins.

(10 mins later) Ok -- this commit should not contain the thumbs anymore ... nor the change to the collapsable fieldsets.

[whikloj]

Thanks @bgilling, that was better there are still some changes in the CSS classes I think as it doesn't look exactly the same.

However, I did some testing and I didn't really see any speed improvement. Perhaps I need to do some tweaking, but for a page with 27,986 issues both the current loading all at once and using Ajax took 186-189 seconds.

There is definitely some processing improvement but the processing time only accounted for 5-6 seconds with the old way.

I think this work is good, but I'm thinking about using this with Solr and faceting the dates so instead of retrieving the entire list of issues you grab the one years list and display all the years.

[wgilling]

@whikloj - are all 27,986 issues from the same year? It almost sounds like the drupal cache needs to be cleared. Our load time went from multiple minutes to a second or two.

[whikloj]

@bgilling Nope, but we were doing some ingesting so I tried it again today and it was much quicker in general. The difference was approximately 6 seconds for 7.x to approximately 4 seconds for your branch.

But maybe we could get someone else to test this out just in case there is something weird in our system. @mjordan ?

[wgilling]

Ok - I just addressed the travis coder issues. Was there anything outstanding before this could be merged?

[whikloj]

@bgilling probably needs an admin page toggle, so people can continue to get their normal functioning until they enable this.

Just a checkbox on the newspaper solution pack admin page to enable Ajax would be good.

[DiegoPino]

@whikloj you were already on this. Seems like @bgilling addressed the toggle thing. Could you give it a last look? Thanks!

[DiegoPino]

@whikloj ping ping. Let me know if you still have time for this. If not could you help me finding another newspaper user that could test this? Thanks!!

[whikloj]

Ok, coming back at this and I notice that it automatically expands the monthly fieldsets and then they can't be collapsed.

Is that expected or it that something in my setup?

[DiegoPino]

@whikloj sorry, don't know... I had issues with collapsing fieldsets in islandora/drupal in the past in bootstrap because of how we at islandora set them up, but can't say for sure here, do you have a sandbox around? If not, no worries, probably already late to get this into the release if there are doubts about missing functionality, code freeze is in like 5 hours or so. But maybe for next one!

[wgilling]

I should be able to take a look at that plops in field set if you tomorrow sometime. It seems like it won't get into the series put that probably isn't a huge deal because I do not think too many institutions have thousands of issues under a single paper. Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Diego Pino Navarro <notifications@github.com> Sent: Wednesday, April 4, 2018 5:40:30 PM To: Islandora/islandora_solution_pack_newspaper Cc: Gillingham Brian; Mention Subject: Re: [Islandora/islandora_solution_pack_newspaper] ISLANDORA-2116 adjusted newspaper display to only load first year iss… (#157) @whikloj<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwhikloj&data=01%7C01%7Cbgilling%40pitt.edu%7C8e95967d725f49e5de5508d59a74b058%7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1&sdata=Ysh%2FVVQ5lbBGC%2B02N0Dja7VjbsOBmAtnNN9jNgOvn00%3D&reserved=0> sorry, don't know... I had issues with collapsing fieldsets in islandora/drupal in the past in bootstrap because of how we at islandora set them up, but can't say for sure here, do you have a sandbox around? If not, no worries, probably already late to get this into the release if there are doubts about missing functionality, code freeze is in like 5 hours or so. But maybe for next one! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FIslandora%2Fislandora_solution_pack_newspaper%2Fpull%2F157%23issuecomment-378754205&data=01%7C01%7Cbgilling%40pitt.edu%7C8e95967d725f49e5de5508d59a74b058%7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1&sdata=6Q2Ga7WR6Zub2gf0wo8ZiHzg0UHvkGYWdFltzwGPgog%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASfilln3ijOMr4X5vFC5BJu9jex-FwXRks5tlT3OgaJpZM4QyesQ&data=01%7C01%7Cbgilling%40pitt.edu%7C8e95967d725f49e5de5508d59a74b058%7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1&sdata=M8jAIS7Ly4h1HJYGG0ra7nOWvkUghmTRY%2FMCf86kHj0%3D&reserved=0>.

[whikloj]

@DiegoPino I don't really have a sandbox, but I can probably put this on our development site.

@bgilling I don't think it takes too many issues to make the collapsible fieldsets nice. Our largest paper is a daily so approximately 300 issues on a page.

I implemented an ajax loader for our newspapers and the fieldsets work to expand and contract.

Perhaps you need the ajax_command_html function to get the fieldsets to render correctly.

[whikloj]

Forgot to add this, but here is our largest newspaper using the ajax year loader. http://digitalcollections.lib.umanitoba.ca/islandora/object/uofm%3A1243378