Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warp path logic to BHF #53

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added warp path logic to BHF #53

wants to merge 4 commits into from

Conversation

msyverw
Copy link

@msyverw msyverw commented Mar 12, 2025

Related PR: Ixrec/Archipelago#7

Changes the in-game tracker logic to send the BHNG warp and BH spawn to the new "Brittle Hollow Northern Glacier" region check for and add a new connection to the BHF to reflect the changes made in the above PR.

Copy link
Owner

@Ixrec Ixrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, sorry, after my update yesterday this apparently requires a rebase/merge

Copy link
Owner

@Ixrec Ixrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested in-game yet, but the overall approach in these two PRs seems viable to me.

Just had a few nitpicks of the content. Also https://github.com/Ixrec/Archipelago/pull/7/files#r2008830711

@msyverw msyverw force-pushed the main branch 2 times, most recently from 98f1bca to 3c74ba6 Compare March 22, 2025 20:30
@Ixrec
Copy link
Owner

Ixrec commented Mar 29, 2025

Haven't tested in-game yet, but

Famous last words.

image

image

ArgumentNullException: Value cannot be null.
Parameter name: source
Stacktrace: System.Linq.Enumerable.Where[TSource] (System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] predicate) (at <55b3683038794c198a24e8a1362bfc61>:0)
ArchipelagoRandomizer.InGameTracker.Logic.GetAllRegionsInRequirements (System.Collections.Generic.IEnumerable`1[T] requires) (at <50df13a76ead4f0db9f30974ae8748ff>:0)
ArchipelagoRandomizer.InGameTracker.Logic.GetLogicDisplayStrings (ArchipelagoRandomizer.InGameTracker.TrackerLocationData data, System.Boolean includeLocationName) (at <50df13a76ead4f0db9f30974ae8748ff>:0)
ArchipelagoRandomizer.InGameTracker.APChecklistMode.SelectChecklistItem (System.Int32 index) (at <50df13a76ead4f0db9f30974ae8748ff>:0)
ArchipelagoRandomizer.InGameTracker.APChecklistMode.UpdateMode () (at <50df13a76ead4f0db9f30974ae8748ff>:0)
(wrapper dynamic-method) ShipLogController.DMD<ShipLogController::Update>(ShipLogController)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants