Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Feldspar logic rule to be more descriptive #54

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Rename Feldspar logic rule to be more descriptive #54

merged 1 commit into from
Mar 22, 2025

Conversation

CrystalSpore
Copy link

Changed from "Feldspar Quick Access" to "Felspar via DB Surface"

@CrystalSpore
Rename Feldspar logic rule to be more descriptive
e5a6a48 
Changed from "Feldspar Quick Access" to "Felspar via DB Surface"
Ixrec
Ixrec approved these changes Mar 21, 2025
View reviewed changes
Copy link
Owner

@Ixrec Ixrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I doubt we'll want the .sh script on main when this is all over, but that's an easy thing to hang onto for now and take out at the end if it makes your job easier.

I'll let you decide when to merge since the apworld PR had an issue.

@Ixrec Ixrec mentioned this pull request Mar 22, 2025
Merged
@Ixrec Ixrec merged commit 854d85e into Ixrec:logic_options_experiment Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ixrec Ixrec Ixrec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CrystalSpore @Ixrec