파일추가 #2
Open
파일추가 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donysony
reviewed
Jun 7, 2023
| .main-box { | ||
| height: 430px; | ||
| width: 1425px; | ||
| background-image: url("../bg.jpeg"); |
There was a problem hiding this comment.
현재 배경이 반복되어서 나오고 있는데 의도하신게 아니라면
background: url(../bg.jpeg) no-repeat center center; 이렇게 작성해보시는건 어떨까요?
no-repeat은 사진을 한번만 보이게 해줘요~
donysony
reviewed
Jun 7, 2023
| <div class="main-box"> | ||
| <div class="profile-box"> | ||
| <div class="profile-picture"> | ||
| <img src="programmer.jpeg" style="width:200px;border-radius:50%" > |
There was a problem hiding this comment.
이미지의 크기를 지정해줄 때 style.css파일 말고 html 태그의 style속성에 css를 작성해준 이유가 따로 있으실까요??
donysony
reviewed
Jun 7, 2023
| float:left; | ||
| color:white; | ||
| font-size:25px; | ||
| margin:0 0 0 0; |
There was a problem hiding this comment.
margin:0 0 0 0;은 margin:0과 같으므로 0 하나만 작성하시면 가독성이 더 좋을 거 같아요!
donysony
reviewed
Jun 7, 2023
| } | ||
|
|
||
| nav a { | ||
| text-decoration: none; |
There was a problem hiding this comment.
a태그의 text-decoration : none;를 99번째 라인에도 주셨는데 이렇게 반복적으로 작성된다면 body에 적용해주면 어떨까요?
donysony
reviewed
Jun 7, 2023
|
|
||
| justify-content : center; | ||
| text-align: center; | ||
| font-family: "jack"; |
There was a problem hiding this comment.
51, 61번째 라인에서도 중복되어 작성하셨는데 body로 옮겨 보시는 건 어떨까요?
body태그에서 한번만 작성하면 되니까 코드 유지 보수할 때 훨씬 수월할 거 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.