Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

파일추가 #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added Righteous-Regular.ttf
Binary file not shown.
Binary file added bg.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
150 changes: 150 additions & 0 deletions css/style.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,150 @@
body{margin: 0;}
@font-face {
font-family: "jack";
src: url("../Righteous-Regular.ttf");
}
header {
background-color: black;
padding: 15px;
margin: 0;
font-family: "jack";
}
h3{
float:left;
color:white;
font-size:25px;
margin:0 0 0 0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

margin:0 0 0 0;은 margin:0과 같으므로 0 하나만 작성하시면 가독성이 더 좋을 거 같아요!

}
nav ul {
list-style-type: none; /*목록의 머리기호 삭제*/
margin: 0;
display: flex;
justify-content: flex-end;
}

nav a {
text-decoration: none;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a태그의 text-decoration : none;를 99번째 라인에도 주셨는데 이렇게 반복적으로 작성된다면 body에 적용해주면 어떨까요?

color:white;
padding: 20px;
font-size: 20px;
}
body{
background-color:black;
}
#container{
display: flex;
flex-wrap: wrap;
height:200px;

justify-content : center;
text-align: center;
font-family: "jack";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

51, 61번째 라인에서도 중복되어 작성하셨는데 body로 옮겨 보시는 건 어떨까요?
body태그에서 한번만 작성하면 되니까 코드 유지 보수할 때 훨씬 수월할 거 같아요

background-color:black;
color:white;
}
#interest{
display: flex;
flex-wrap: wrap;
height:200px;
justify-content : right;
text-align: center;
font-family: "jack";
background-color:black;
color:white;
}
#detail{
display: flex;
flex-wrap: wrap;
height:200px;
justify-content : center;
text-align: center;
font-family: "jack";
background-color:black;
color:white;
}
#container p {
height:1000px;
color:white;
}
.fa {
padding: 20px;
font-size: 30px;
width: 50px;
text-align: center;
text-decoration: none;
}
.fa:hover {
opacity: 0.7;
}
.fa-facebook {
background: #3B5998;
color: white;
}
.fa-twitter {
background: #55ACEE;
color: white;
}
.fa-skype{
background:#55ACEE;
color:white;
}
.fa-linkedin{
background: #55ACEE;
color:white;
}
.fa-rss{
background:orange;
color:white;
}
.profile-icon a {
display: inline-block;
margin: 10px;
text-decoration: none;
border: 2px solid white;
border-radius: 50%;
padding: 8px;
width: 15px;
}
.profile-picture {
width: 200px;
height: 140px;
border-radius: 50%;
overflow: hidden;
margin: 0 auto 1em;
border: 0.5em solid black;
box-shadow: 0 0 0.1em 1.5em mintcream;
}
.profile-box {
width: 300px;
height: 355px;
background: black;
border-radius: 30px;
position: absolute;
left: 40%;
top: 100px;
}

.title-name,.title-nickname {
margin: 20px;
text-align: center;
font-family: "jack";
color:white;
}
.main-box {
height: 430px;
width: 1425px;
background-image: url("../bg.jpeg");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재 배경이 반복되어서 나오고 있는데 의도하신게 아니라면
background: url(../bg.jpeg) no-repeat center center; 이렇게 작성해보시는건 어떨까요?
no-repeat은 사진을 한번만 보이게 해줘요~

}
table{
width:300px;
margin: 10px;

}
/*
@media all and (max-width: 600px){
#container, nav{
flex-direction: column;
}
}

*/
102 changes: 102 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>Hyukjin Web Site</title>
<link rel="stylesheet" href="css/style.css">
<!-- Add icon library -->
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css">
</head>
<body>
<header>
<h3>Ko</h3>
<nav>
<ul>
<li><a href="#">HOME</a></li>
<li><a href="#">ABOUT</a></li>
<li><a href="#">SKILLS</a></li>
<li><a href="#">RESUME</a></li>
<li><a href="#">PORTFOLIO</a></li>
<li><a href="#">CONTACT</a></li>
</ul>
</nav>
</header>
<div class="main-box">
<div class="profile-box">
<div class="profile-picture">
<img src="programmer.jpeg" style="width:200px;border-radius:50%" >
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지의 크기를 지정해줄 때 style.css파일 말고 html 태그의 style속성에 css를 작성해준 이유가 따로 있으실까요??

</div>
<div class="title-name">
<h1>hyukjin Ko</h1>
</div>
<div class="title-nickname">
<h2>Backend Developer</h2>
</div>
<div class="profile-icon">
<a href="#" class="fa fa-facebook"></a>
<a href="#" class="fa fa-twitter"></a>
<a href="#" class="fa fa-skype"></a>
<a href="#" class="fa fa-linkedin"></a>
<a href="#" class="fa fa-rss"></a>

</div>
</div>
</div>
<div id="container">

<h2>About Me</h2>
<p>
Lorem ipsum dolor sit amet consectetur adipisicing elit. Perferendis tempore minima at, rem nesciunt odio animi obcaecati necessitatibus modi, doloribus aspernatur quaerat nobis, dolorem repellendus eius corporis dolores minus delectus.
</p>
</div>
<div id="detail">
<table>
<tr>
<td colspan='2'>Personal Details</td>
</tr>
<tr>
<td>Birthdate</td>
<td>08-06-1998</td>
</tr>
<tr>
<td>Phone</td>
<td>+82 10-4614-5972</td>
</tr>
<tr>
<td>Email</td>
<td>1rhgurwls1@naver.com</td>
</tr>
<tr>
<td>website</td>
<td>.....@........</td>
</tr>
<tr>
<td>ADDRESS</td>
<td>SEOUL, KOREA</td>
</tr>
</table>

<table>
<tr>
<td colspan='4'>My Interests</td>
</tr>
<tr>
<td><img src="">GAMES</td>
<td><img src="">MUSIC</td>
<td><img src="">TRAVEL</td>
<td><img src="">MAC OS</td>
</tr>
<tr>
<td><img src="">CINEMA</td>
<td><img src="">COFFEE</td>
<td><img src="">CARS</td>
<td><img src="">MONEY</td>
</tr>

</table>

</div>


</body>
</html>
Binary file added programmer.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.