Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the gsi-addon-dev environment to Python 3.11.7 #1252

Merged
merged 31 commits into from
Aug 28, 2024

Conversation

DavidHuber-NOAA
Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA commented Aug 19, 2024

Summary

This updates the Python version to 3.11.7 and pull upstream Python modules required for the EMC_Verif-Global verification system.
Resolves #942

Testing

Concretized and built on Hera: /scratch1/NCEPDEV/global/David.Huber/SPACK/ss_python_3117/envs/met913_down

Applications affected

Global-workflow, EMC_verif-global

Systems affected

Hercules, Hera, Jet, S4, Orion, Gaea, NOAA Cloud

Dependencies

#1217

Issue(s) addressed

#942

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

climbfuji and others added 18 commits August 5, 2024 12:03
…kage and in py-xnrl about the +delayed variant
@climbfuji
Copy link
Collaborator

macOS CI fails because it can't build the old met@9.1.3: https://github.com/JCSDA/spack-stack/actions/runs/10457030063/job/28955724712

@climbfuji
Copy link
Collaborator

Note. The oneapi build also fails compiling met@9.1.3, with the same errors as the apple-clang build (not surprising, both LLVM based). So I guess the oneapi compilers are the end of the emc_verif package and one more strong reason to switch to the new verification system.

How to proceed here? Keep building a separate gsi-addon-env (but still unifying the Python underneath)?

@DavidHuber-NOAA
Copy link
Collaborator Author

@climbfuji Yeah, I think we will need to retain the gsi-addon-env and update the Python version to 3.11.7 (currently 3.11.6). Working on a test build now and I will update this PR description accordingly.

@DavidHuber-NOAA DavidHuber-NOAA changed the title Add METplus/MET v3.1.1/9.1.3 to the unified-env package matrix Update the gsi-addon-dev environment to Python 3.11.7 Aug 19, 2024
…pack-stack into feature/MET_METp_3.1.1

* 'feature/MET_METp_3.1.1' of github.com:davidhuber-noaa/spack-stack:
  Revert mandatory met/metplus versions in the global-workflow env
  Update to Python 3.11.7 in the gsi-addon and pull upstream python packages
  Add MET/METplus v9.1.3/v3.1.1 to the unified-env requirements matrix
  Add 'py-dask +delayed' to gmao-swell-env and add comments in that package and in py-xnrl about the +delayed variant (JCSDA#1246)
@DavidHuber-NOAA
Copy link
Collaborator Author

I have a successful test build of the gsi-addon-dev environment available here: /scratch1/NCEPDEV/global/David.Huber/SPACK/ss_python_3117/envs/met913_down. I will test it out some more tomorrow.

@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Aug 21, 2024
3 tasks
DavidHuber-NOAA and others added 3 commits August 22, 2024 13:55
* jcsda/develop:
  Bump Python to 3.11.7 (JCSDA#1217)
  Add a clause in the cleanup to fix directory permissions (JCSDA#1273)
  Bug fix: configure neptune-env variants in three templates: neptune-dev, skylab-dev, unified-dev (JCSDA#1268)
  Update site configs for Atlantis, Narwhal, Nautilus (JCSDA#1266)
  Configuration for bufr_query@0.0.2 and eckit@1.27.0 (JCSDA#1240)
@DavidHuber-NOAA
Copy link
Collaborator Author

@climbfuji @AlexanderRichert-NOAA I think this is ready to be reviewed/merged. It works for all global-workflow submodules except EMC_verif-global due to matplotlib issues, and we have a separate issue to track that.

@AlexanderRichert-NOAA
Copy link
Collaborator

Cool-- I'm going to test one possible change then review/approve

@AlexanderRichert-NOAA
Copy link
Collaborator

AlexanderRichert-NOAA commented Aug 27, 2024

This is related to @climbfuji's question-- Can we revert packages.yaml to keep it clean, but then add the following block to the gsi-addon-dev template?

    met:
      require:: '@9.1.3 +python +grib2'
    metplus:
      require:: '@3.1.1'

This will override what's in common/packages.yaml for those specific packages.

@DavidHuber-NOAA
Copy link
Collaborator Author

@AlexanderRichert-NOAA I like that suggestion. I'll give that a try.

@DavidHuber-NOAA
Copy link
Collaborator Author

@AlexanderRichert-NOAA Done. This concretized correctly.

Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@climbfuji climbfuji merged commit 181a187 into JCSDA:develop Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gsi-addon-dev to include Python modules
3 participants